Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 758647 - media-sound/beets-1.4.9 compiles manpages but they are already included in the source
Summary: media-sound/beets-1.4.9 compiles manpages but they are already included in th...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Guillaume Seren
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-05 12:51 UTC by Simon
Modified: 2021-01-18 12:27 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon 2020-12-05 12:51:13 UTC
The source dist for beets already includes pre"compiled" manpages, see the beets-1.4.9/man directory in the source dist file (https://files.pythonhosted.org/packages/3a/a8/6ac61e3ca16da6278c681381ed392bc02e6d410ea3ff3a4af34de1379b38/beets-1.4.9.tar.gz from https://pypi.org/project/beets/#files)
So the dependency on and invocation of sphinx for this isn't necessary.


Reproducible: Always
Comment 1 Simon 2020-12-06 18:45:46 UTC
FYI Whilst the description now says 1.4.9 this also applies to the 9999 ebuild
Comment 2 Guillaume Seren 2020-12-09 13:03:27 UTC
Hello Simon,
thank you for this report.

(In reply to Simon from comment #0)
> The source dist for beets already includes pre"compiled" manpages, see the
> beets-1.4.9/man directory in the source dist file

Yes this is true, we could use that pre-compiled version,
when I was working on this package I used only the source.

> So the dependency on and invocation of sphinx for this isn't necessary.

Yes we can change that, I compared the two version pre-built and generated,
and the result is really close, so I think it can be done, I am asking to other maintainer what they think about this.

Here https://github.com/gentoo/gentoo/pull/16046 is the main ongoing work on beet for gentoo, please test it if you can.
Comment 3 Guillaume Seren 2020-12-09 19:55:34 UTC
Simon,
I have added a commit with to use the pre-generated man page from the tarball,
and dropped the sphinx deps (except you are building html doc).

Please check it if you can, and send a feedback here.

Thank you.
Comment 4 Larry the Git Cow gentoo-dev 2021-01-18 12:27:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fbddb8ec8d54d2e1ec001d97f3e52c81deb7043f

commit fbddb8ec8d54d2e1ec001d97f3e52c81deb7043f
Author:     Guillaume Seren <guillaumeseren@gmail.com>
AuthorDate: 2020-12-09 19:45:36 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-01-18 12:27:05 +0000

    media-sound/beets: Use pre-builded man page
    
    Closes: https://bugs.gentoo.org/758647
    Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/16046
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-sound/beets/beets-1.4.9-r3.ebuild | 7 ++++---
 media-sound/beets/beets-9999.ebuild     | 7 ++++---
 2 files changed, 8 insertions(+), 6 deletions(-)