Created attachment 676633 [details] libopenaptx-9999.ebuild Codecs for Bluetooth aptX and aptX HD Used by pipewire master Ebuild attatched
why is use cpu_flags_x86_avx2 && append-cflags "-mavx2" append-cflags "-O3" needed?
(In reply to Jonas Stein from comment #1) > why is > use cpu_flags_x86_avx2 && append-cflags "-mavx2" > append-cflags "-O3" > > needed? It is what the author of the library recommends for performance.
(In reply to Joakim Tjernlund from comment #2) > (In reply to Jonas Stein from comment #1) > > why is > > use cpu_flags_x86_avx2 && append-cflags "-mavx2" > > append-cflags "-O3" > > > > needed? > > It is what the author of the library recommends for performance. I guess one can loose the -O3 flag though and leave it the user.
Maybe something for the new codec group ?
With a PR, I'd be happy to look at this.
(In reply to Sam James from comment #5) > With a PR, I'd be happy to look at this. What's wrong with the included ebuild?
(In reply to Joakim Tjernlund from comment #6) > (In reply to Sam James from comment #5) > > With a PR, I'd be happy to look at this. > > What's wrong with the included ebuild? I prefer to review PRs personally, lacks metadata, and it’s a live ebuild.
(In reply to Sam James from comment #7) > (In reply to Joakim Tjernlund from comment #6) > > (In reply to Sam James from comment #5) > > > With a PR, I'd be happy to look at this. > > > > What's wrong with the included ebuild? > > I prefer to review PRs personally, lacks metadata, and it’s a live ebuild. Too long time has passed for me to do the clone/push work which essentially jsust duplicates the work already done, sorry.
(In reply to Joakim Tjernlund from comment #8) > (In reply to Sam James from comment #7) > > (In reply to Joakim Tjernlund from comment #6) > > > (In reply to Sam James from comment #5) > > > > With a PR, I'd be happy to look at this. > > > > > > What's wrong with the included ebuild? > > > > I prefer to review PRs personally, lacks metadata, and it’s a live ebuild. > > Too long time has passed for me to do the clone/push work which essentially > jsust duplicates the work already done, sorry. It’s not really a duplication of work given it contains everything other than the ebuild and it’s just how I prefer to review. A patch via git format-patch would work too if you had to.
(In reply to Sam James from comment #9) > (In reply to Joakim Tjernlund from comment #8) > > (In reply to Sam James from comment #7) > > > (In reply to Joakim Tjernlund from comment #6) > > > > (In reply to Sam James from comment #5) > > > > > With a PR, I'd be happy to look at this. > > > > > > > > What's wrong with the included ebuild? > > > > > > I prefer to review PRs personally, lacks metadata, and it’s a live ebuild. > > > > Too long time has passed for me to do the clone/push work which essentially > > jsust duplicates the work already done, sorry. > > It’s not really a duplication of work given it contains everything other > than the ebuild and it’s just how I prefer to review. A patch via git > format-patch would work too if you had to. (Also, ideally we'd have changes to enable support in pipewire.)
Created attachment 691914 [details, diff] Patch with libopenaptx ebuilds
(In reply to Joakim Tjernlund from comment #11) > Created attachment 691914 [details, diff] [details, diff] > Patch with libopenaptx ebuilds Thank you -- can you include the GCO sign off in a comment here or in the patch? (Signed-off-by: Name <email>)
Created attachment 691917 [details, diff] signoffed patch
(In reply to Sam James from comment #10) > (In reply to Sam James from comment #9) > > (In reply to Joakim Tjernlund from comment #8) > > > (In reply to Sam James from comment #7) > > > > (In reply to Joakim Tjernlund from comment #6) > > > > > (In reply to Sam James from comment #5) > > > > > > With a PR, I'd be happy to look at this. > > > > > > > > > > What's wrong with the included ebuild? > > > > > > > > I prefer to review PRs personally, lacks metadata, and it’s a live ebuild. > > > > > > Too long time has passed for me to do the clone/push work which essentially > > > jsust duplicates the work already done, sorry. > > > > It’s not really a duplication of work given it contains everything other > > than the ebuild and it’s just how I prefer to review. A patch via git > > format-patch would work too if you had to. > > (Also, ideally we'd have changes to enable support in pipewire.) That is a change for another day, ATM I paused pipewire as it was a bit too unstable for me. pipewire needs openrc loved in Gentoo as well.
(In reply to Joakim Tjernlund from comment #14) > > That is a change for another day, ATM I paused pipewire as it was a bit too > unstable for me. pipewire needs openrc loved in Gentoo as well. No problem. 1) Are you interested in maintaining this (with me)? 2) Someone actually posted https://github.com/gentoo/gentoo/pull/19965 just after you said that re OpenRC :D
CCing pipewire maintainers so they're aware.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4722b0a0ea44624f07a39dc2cfac6b58b1879798 commit 4722b0a0ea44624f07a39dc2cfac6b58b1879798 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-03-17 01:14:55 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-03-17 01:16:08 +0000 media-libs/libopenaptx: update maintainers (me then codec@) This will be a dependency of Pipewire. Closes: https://bugs.gentoo.org/758377 Signed-off-by: Sam James <sam@gentoo.org> media-libs/libopenaptx/metadata.xml | 4 ++++ 1 file changed, 4 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f411b6a48680122d54db515b256edcfe706973a2 commit f411b6a48680122d54db515b256edcfe706973a2 Author: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> AuthorDate: 2021-03-16 23:54:12 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-03-17 01:16:03 +0000 media-libs/libopenaptx: new package * Add libopenaptx-0.2.0/9999 ebuilds Closes: https://bugs.gentoo.org/758377 Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> Signed-off-by: Sam James <sam@gentoo.org> media-libs/libopenaptx/Manifest | 1 + media-libs/libopenaptx/libopenaptx-0.2.0.ebuild | 39 +++++++++++++++++++++++++ media-libs/libopenaptx/libopenaptx-9999.ebuild | 39 +++++++++++++++++++++++++ media-libs/libopenaptx/metadata.xml | 8 +++++ 4 files changed, 87 insertions(+) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=99aeb4db26dbd9fc4cc19b915349e6060c3cd0b4 commit 99aeb4db26dbd9fc4cc19b915349e6060c3cd0b4 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-03-17 01:19:47 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-03-17 01:22:01 +0000 media-libs/libopenaptx: fixes to prepare for tree * Update LICENSE to LGPL-2.1+ * Respect CC and AR * Drop ~x86 keyword until tested * Style changes (inc. block structure, variable style) * Don't use ${D} in src_compile Bug: https://bugs.gentoo.org/758377 Signed-off-by: Sam James <sam@gentoo.org> media-libs/libopenaptx/libopenaptx-0.2.0.ebuild | 36 ++++++++++++++++--------- media-libs/libopenaptx/libopenaptx-9999.ebuild | 36 ++++++++++++++++--------- 2 files changed, 46 insertions(+), 26 deletions(-)
(In reply to Sam James from comment #15) > (In reply to Joakim Tjernlund from comment #14) > > > > That is a change for another day, ATM I paused pipewire as it was a bit too > > unstable for me. pipewire needs openrc loved in Gentoo as well. > > No problem. > > 1) Are you interested in maintaining this (with me)? Sure, already got a maintainer bug https://bugs.gentoo.org/700218 > > 2) Someone actually posted https://github.com/gentoo/gentoo/pull/19965 just > after you said that re OpenRC :D Nice, heading over for a look ...
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6008292871a3bd3528d8e5e787c80206db5f115c commit 6008292871a3bd3528d8e5e787c80206db5f115c Author: Sam James <sam@gentoo.org> AuthorDate: 2021-03-17 01:42:34 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-03-17 01:43:01 +0000 media-libs/libopenaptx: add Joakim as a maintainer too Bug: https://bugs.gentoo.org/758377 Signed-off-by: Sam James <sam@gentoo.org> media-libs/libopenaptx/metadata.xml | 4 ++++ 1 file changed, 4 insertions(+)
Turns out that I didn't think about keywording for other archs. Pipewire needs more. There is nothing in libopenaptx that is arch specific I think. Sam, could you add KEYWORDS=~arm ~arm64 ~ppc ~ppc64 ~x86 ?
(In reply to Joakim Tjernlund from comment #20) > Turns out that I didn't think about keywording for other archs. Pipewire > needs more. There is nothing in libopenaptx that is arch specific I think. > > Sam, could you add > KEYWORDS=~arm ~arm64 ~ppc ~ppc64 ~x86 > ? According to the author(pali) there are no restrictions.
Arch keywording is done by arch teams, you need an actual arch image to test build.
(In reply to Andreas Sturmlechner from comment #22) > Arch keywording is done by arch teams, you need an actual arch image to test > build. OK, so I need to file a KEYWORDING bug for those arches? Never done that, is it OK if I just try?
(In reply to Joakim Tjernlund from comment #23) > (In reply to Andreas Sturmlechner from comment #22) > > Arch keywording is done by arch teams, you need an actual arch image to test > > build. > > OK, so I need to file a KEYWORDING bug for those arches? > Never done that, is it OK if I just try? After looking a bit on keywording bugs I went ahead: https://bugs.gentoo.org/776940
