Soundconverter version 4.0.0 was released upstream on October 20, 2020.
Please bump as with recent upgrade to python3_9 it's one of the packages now which still need python3_8.
Yes please add python3_9 and python3_10 support and bump to 4.0 to continue to use soundconverter i uninstall the gentoo and installed flatpak.... not good :(
Created attachment 781526 [details] soundconverter-4.0.3.ebuild Please try the attached ebuild. Signed-off-by: Sam James <sam@gentoo.org>
Created attachment 781529 [details] soundconverter-4.0.3.ebuild With PV >= 4, developer employs distutils-extra to install. Extracting process used by other ebuild devs, process was applied to install package. Process appears successful with file collisions (especially in glib-2.0 directories!) nor QA Notices (/usr/share/doc/...). This should be process for install until upstream incorporates better PEP-compliant install process. Drawback is another package build dependency on dev-python/distutils-extra.
(In reply to Scott Furry from comment #4) > Created attachment 781529 [details] > Ebuild utilizing built-in distutils-extra methods > > With PV >= 4, developer employs distutils-extra to install. Extracting > process used by other ebuild devs, process was applied to install package. > Process appears successful with file collisions (especially in glib-2.0 > directories!) nor QA Notices (/usr/share/doc/...). > Yep, I gave up after not being able to get the tests working, which is why it wasn't committed. Didn't get so far as figuring out QA notices given I didn't play with installation either. I don't know why you've dropped src_test entirely along with the rest of my changes? Rest of it seems reasonable enough. Do tests pass for you now? (ebuild ... clean test install)
Second para "...with file..." should read "...with no file..." tl;dr - ebuild works well
(In reply to Sam James from comment #5) > (In reply to Scott Furry from comment #4) > > Created attachment 781529 [details] > > Ebuild utilizing built-in distutils-extra methods > > > > With PV >= 4, developer employs distutils-extra to install. Extracting > > process used by other ebuild devs, process was applied to install package. > > Process appears successful with file collisions (especially in glib-2.0 > > directories!) nor QA Notices (/usr/share/doc/...). > > > > Yep, I gave up after not being able to get the tests working, which is why > it wasn't committed. Didn't get so far as figuring out QA notices given I > didn't play with installation either. > > I don't know why you've dropped src_test entirely along with the rest of my > changes? > > Rest of it seems reasonable enough. Do tests pass for you now? (ebuild ... > clean test install) Imagine that... (snip from output) --- >>> Source compiled. >>> Test phase: media-sound/soundconverter-4.0.3 >>> Completed testing media-sound/soundconverter-4.0.3 ---
That appears to not be running anything.
(In reply to Sam James from comment #8) > That appears to not be running anything. Possible that testing variable (i.e. what test methodology to be used) has to be declared. I recall tripping over that not long ago with another ebuild. FWIW - this should also address #849092 once I|us|someone gets testing sorted out.
(In reply to Scott Furry from comment #9) > (In reply to Sam James from comment #8) > > That appears to not be running anything. > > Possible that testing variable (i.e. what test methodology to be used) has > to be declared. I recall tripping over that not long ago with another ebuild. > So, for Makefiles, the default works fine because it'll run emake check (or emake test), but for Python stuff, that doesn't do anything (it checks if the target exists first). That's what the distutils_enable_tests stuff did in mine. I don't mind doing the combination of the two things (yours and mine) though. It'd be interesting to know if they hang for you if you copy in the python_test, src_test, distutils_enable_tests line, and the test dependencies. Also, could you post your Signed-off-by line like I did, so I can use your ebuild? I assume this works OK for you at runtime?
Realized that upstream is using unittest not unittest2. App executes as expected. Adding --- python_test() { esetup.py test } --- to end of ebuild allows tests to be initiated and then spits out a long winded error message ending with: --- File "/var/tmp/portage/media-sound/soundconverter-4.0.3/work/soundconverter-4.0.3/soundconverter/gstreamer/converter.py", line 73, in find_available_elements have_it = bool(Gst.ElementFactory.find(encoder)) File "/usr/lib/python3.9/site-packages/gi/overrides/Gst.py", line 694, in fake_method raise NotInitialized("Please call Gst.init(argv) before using GStreamer") gi.overrides.Gst.NotInitialized: Please call Gst.init(argv) before using GStreamer --- I'm out of my depth on this one. Will dig into "sign-off" as requested.
Comment on attachment 781529 [details] soundconverter-4.0.3.ebuild Ebuild utilizing built-in distutils-extra methods
(In reply to Scott Furry from comment #12) > Comment on attachment 781529 [details] > soundconverter-4.0.3.ebuild > > Ebuild utilizing built-in distutils-extra methods Signed-off-by: Scott Furry <scott.wl.furry@gmail.com>
Tried to incorporate testing from Sam James' ebuild. Attempt failed with reporting of "distutils_install_for_testing is not implemented in PEP517 mode". And I'm very much out of my depth here.
(In reply to Scott Furry from comment #14) > Tried to incorporate testing from Sam James' ebuild. > Attempt failed with reporting of "distutils_install_for_testing is not > implemented in PEP517 mode". > > And I'm very much out of my depth here. No problem, thanks a lot for your help -- I'll combine the two, but most of my changes ended up being no-ops given tests seem to hang for me anyway :) Much appreciated!
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5faee21836cdcd724ca89df47ae28620d5a56ad9 commit 5faee21836cdcd724ca89df47ae28620d5a56ad9 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-05-31 04:03:46 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-05-31 04:07:00 +0000 media-sound/soundconverter: add partial test infrastructure; minor QA touchups Closes: https://bugs.gentoo.org/758197 Bug: https://bugs.gentoo.org/846092 Signed-off-by: Sam James <sam@gentoo.org> .../soundconverter/soundconverter-4.0.3.ebuild | 47 +++++++++++++++++++--- 1 file changed, 41 insertions(+), 6 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=976952fe40b45059bba077f0964df99baf44f9f6 commit 976952fe40b45059bba077f0964df99baf44f9f6 Author: Scott Furry <scott.wl.furry@gmail.com> AuthorDate: 2022-05-31 03:59:09 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-05-31 04:06:59 +0000 media-sound/soundconverter: add 4.0.3 Closes: https://bugs.gentoo.org/758197 Closes: https://bugs.gentoo.org/846092 Signed-off-by: Scott Furry <scott.wl.furry@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> media-sound/soundconverter/Manifest | 1 + .../soundconverter/soundconverter-4.0.3.ebuild | 64 ++++++++++++++++++++++ 2 files changed, 65 insertions(+)