Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 757519 - app-shells/bash-5.1_rc3 has a bad sed expression that will affect non-rc builds.
Summary: app-shells/bash-5.1_rc3 has a bad sed expression that will affect non-rc builds.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal major
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-11-29 00:38 UTC by Jacob Floyd
Modified: 2020-11-29 19:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch for 5.1_rc3 (bash-5.1_rc3.ebuild.patch,509 bytes, patch)
2020-11-29 00:43 UTC, Jacob Floyd
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jacob Floyd 2020-11-29 00:38:29 UTC
In bash-5.1_rc3, there is a sed expression that makes bash use the system readline. That expression fails with the 5.1 sources because it is only looking for $(RL_*) but it should also look for ${RL_*}.

Reproducible: Always

Steps to Reproduce:
Currently, the the sed expression is only triggered for non-rc ebuilds.
1. Adjust the ebuild so that is_release() returns 0
2. Emerge bash-5.1_rc3
Actual Results:  
The build fails. I was testing on darwin prefix, but this should be a general problem, and it is not a prefix-specific issue.

Expected Results:  
builds

I will attach a patch. The change is very minor.
Comment 1 Jacob Floyd 2020-11-29 00:43:36 UTC
Created attachment 675652 [details, diff]
ebuild patch for 5.1_rc3

This is the fixed line (merely add {})

> -		sed -ri -e 's:\$[(](RL|HIST)_LIBSRC[)]/[[:alpha:]]*.h::g' Makefile.in || die
> +		sed -ri -e 's:\$[{(](RL|HIST)_LIBSRC[)}]/[[:alpha:]]*.h::g' Makefile.in || die

This works for me.
Comment 2 Jacob Floyd 2020-11-29 00:45:15 UTC
To be clear:
This issue will not affect anyone right now because 5.1 is still an rc. Once it is actually released, then this bug will manifest. Here's a pre-emptive fix.
Comment 3 Larry the Git Cow gentoo-dev 2020-11-29 19:11:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ff8585b1392be68d9613fb377fda7c0da0f891f5

commit ff8585b1392be68d9613fb377fda7c0da0f891f5
Author:     Jacob Floyd <cognifloyd+gentoobugs@gmail.com>
AuthorDate: 2020-11-29 18:27:49 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2020-11-29 19:11:34 +0000

    app-shells/bash: Fix sed call for using system-readline
    
    Closes: https://bugs.gentoo.org/757519
    Package-Manager: Portage-3.0.11, Repoman-3.0.2
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 app-shells/bash/bash-5.1_rc3.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ba04c1e8c19c6e32fbb04705db227aeed983e8d9

commit ba04c1e8c19c6e32fbb04705db227aeed983e8d9
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2020-11-29 19:03:55 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2020-11-29 19:11:35 +0000

    app-shells/bash: Backport system-readline sed fixes
    
    Bug: https://bugs.gentoo.org/757519
    Package-Manager: Portage-3.0.11, Repoman-3.0.2
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 app-shells/bash/bash-2.05b_p13.ebuild  | 2 +-
 app-shells/bash/bash-3.0_p22.ebuild    | 2 +-
 app-shells/bash/bash-3.1_p23.ebuild    | 2 +-
 app-shells/bash/bash-3.2_p57.ebuild    | 2 +-
 app-shells/bash/bash-4.0_p44.ebuild    | 2 +-
 app-shells/bash/bash-4.1_p17.ebuild    | 2 +-
 app-shells/bash/bash-4.2_p53.ebuild    | 2 +-
 app-shells/bash/bash-4.3_p48-r2.ebuild | 2 +-
 app-shells/bash/bash-4.4_p23-r2.ebuild | 2 +-
 app-shells/bash/bash-5.0_p18.ebuild    | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d1596808dc519e3857ed2130cd25d6f5615e17d7

commit d1596808dc519e3857ed2130cd25d6f5615e17d7
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2020-11-29 18:58:57 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2020-11-29 19:11:34 +0000

    app-shells/bash: Added more fixes to the system-readline sed call
    
    Bug: https://bugs.gentoo.org/757519
    Package-Manager: Portage-3.0.11, Repoman-3.0.2
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 app-shells/bash/bash-5.1_rc3.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)