Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 756277 - dev-libs/libgit2: uses bundled PCRE(?)
Summary: dev-libs/libgit2: uses bundled PCRE(?)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-24 02:31 UTC by Sam James
Modified: 2020-11-24 08:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-11-24 02:31:22 UTC
I _think_ libgit2 might be using a bundled PCRE automagically but I can't fully tell: https://github.com/libgit2/libgit2/blob/ae30009e3d1312bf2a3816d40ba3c73587304068/src/CMakeLists.txt#L119.

The "bundled libpcre" line in https://github.com/libgit2/libgit2/blob/d9d86e41890acb32ed47ddd3a88b2ff2856818de/docs/changelog.md#changes-or-improvements-1 is what indicated me that there might be something going on.
Comment 1 Ionen Wolkens gentoo-dev 2020-11-24 02:53:57 UTC
- System with dev-libs/libpcre installed (libgit2 linked against it):
$ strings /usr/lib64/libgit2.so.1.1.0 | grep -c 'pattern error'
0

- System without dev-libs/libpcre (libgit2 didn't find it)
$ strings /usr/lib64/libgit2.so.1.1.0  | grep -c 'pattern error'
1

'pattern error' is defined in libgit2-1.1.0/deps/pcre/pcreposix.c
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-11-24 07:51:28 UTC
-- Found PCRE: /usr/lib64/libpcre.so

...but the dep is indeed missing.
Comment 3 Larry the Git Cow gentoo-dev 2020-11-24 08:18:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=692dcf4f8e4428d5de39ff3aee0737355cf06cd0

commit 692dcf4f8e4428d5de39ff3aee0737355cf06cd0
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-11-24 07:54:53 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-11-24 08:03:43 +0000

    dev-libs/libgit2: Add missing dep on pcre2
    
    Closes: https://bugs.gentoo.org/756277
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-libs/libgit2/{libgit2-1.0.1.ebuild => libgit2-1.0.1-r1.ebuild}   | 5 +++--
 .../libgit2/{libgit2-1.1.0-r1.ebuild => libgit2-1.1.0-r2.ebuild}     | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)