Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 755977 - sci-visualization/paraview: Must not rely on QT_SELECT
Summary: sci-visualization/paraview: Must not rely on QT_SELECT
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Matthias Maier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qtbindir
  Show dependency tree
 
Reported: 2020-11-21 18:20 UTC by Andreas Sturmlechner
Modified: 2020-11-25 16:24 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2020-11-21 18:20:35 UTC
This depends on qtchooser which has no future.
Comment 1 Andreas Sturmlechner gentoo-dev 2020-11-22 00:26:54 UTC
Build system indeed seems to rely on it, which means it needs fixing upstream especially since it fails to `find_package(Qt5XmlPatterns)` in the first place.


CMake Error at CMake/ParaViewClient.cmake:587 (message):
  Failed to convert servermanager XML: xmlpatterns: could not find a Qt
  installation of ''

make[2]: *** [Clients/ParaView/Documentation/CMakeFiles/paraview_doc.dir/build.make:88: Clients/ParaView/Documentation/paraview_doc.xslt] Error 1
make[2]: Leaving directory 'paraview-5.8.1_build'
make[1]: *** [CMakeFiles/Makefile2:25690: Clients/ParaView/Documentation/CMakeFiles/paraview_doc.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....


In CMake/ParaViewClient.cmake, they're just making bad assumptions about path:

  include("${_ParaViewClient_cmake_dir}/paraview-find-package-helpers.cmake" OPTIONAL)
  find_program(qt_xmlpatterns_executable
    NAMES xmlpatterns-qt5 xmlpatterns
    HINTS "${Qt5_DIR}/../../../bin"
          "${Qt5_DIR}/../../../libexec/qt5/bin"
    DOC   "Path to xmlpatterns")
  mark_as_advanced(qt_xmlpatterns_executable)

  if (NOT qt_xmlpatterns_executable)
    message(FATAL_ERROR
      "Cannot find the xmlpatterns executable.")
  endif ()
Comment 2 Larry the Git Cow gentoo-dev 2020-11-25 16:10:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9905e1b6a085a2fe98b550d775b8ba158f76d8fc

commit 9905e1b6a085a2fe98b550d775b8ba158f76d8fc
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-11-25 15:56:59 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-11-25 16:10:40 +0000

    sci-visualization/paraview: Inject path to xmlpatterns, drop QT_SELECT
    
    Closes: https://bugs.gentoo.org/755977
    Package-Manager: Portage-3.0.10, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/paraview-5.8.1-find-xmlpatterns.patch    | 38 ++++++++++++++++++++++
 sci-visualization/paraview/paraview-5.8.1.ebuild   |  2 ++
 2 files changed, 40 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2020-11-25 16:24:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ea0422d2924f06264e4e69e7df0c5e4fe266bd4e

commit ea0422d2924f06264e4e69e7df0c5e4fe266bd4e
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-11-25 16:12:07 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-11-25 16:24:11 +0000

    sci-visualization/paraview: Really drop QT_SELECT this time
    
    Closes: https://bugs.gentoo.org/755977
    Package-Manager: Portage-3.0.10, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 sci-visualization/paraview/paraview-5.8.1.ebuild | 4 ----
 1 file changed, 4 deletions(-)