Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 755857 - media-video/mpv-0.32.0-r1: requires now-gone "harfbuzz" flag for media-libs/libass
Summary: media-video/mpv-0.32.0-r1: requires now-gone "harfbuzz" flag for media-libs/l...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-20 17:31 UTC by Daniel Pouzzner
Modified: 2020-11-20 18:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Pouzzner 2020-11-20 17:31:09 UTC
Portage environment is ~amd64.

When mpv is built with the libass use flag, it depends on the harfbuzz flag in libass, which was just removed in libass-0.15.0 (~amd64):

mpv-0.32.0-r1.ebuild:

        libass? (
                >=media-libs/libass-0.12.1:=[fontconfig,harfbuzz(+)]
                virtual/ttf-fonts
        )

diff -up /usr/portage/media-libs/libass/{libass-0.14.0.ebuild,libass-0.15.0.ebuild} | fgrep IUSE:

-IUSE="+fontconfig +harfbuzz static-libs"
+IUSE="+fontconfig"
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-11-20 17:33:26 UTC
I'm not sure I understand. 

Harfbuzz is now a hard dependency upstream in libass => the USE flag was dropped.
In mpv, all we can do is say "if it's not present, assume it's on".

See https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d79551f66ff6e65b64d87a2060e546029d39ed8.

What problem are you actually hitting?
Comment 2 Daniel Pouzzner 2020-11-20 17:38:37 UTC
The mpv ebuild just needs to provide the dependency as "|| (>=media-libs/libass-0.15.0:=[fontconfig] >=media-libs/libass-0.12.1:=[fontconfig,harfbuzz(+)])".  Untested but that seems to be the way.


Behavior with current ebuild:



WARNING: One or more updates/rebuilds have been skipped due to a dependency conflict:

media-libs/libass:0

  (media-libs/libass-0.15.0:0/9::gentoo, ebuild scheduled for merge) USE="fontconfig" ABI_X86="(64) -32 (-x32)" conflicts with
    >=media-libs/libass-0.12.1:0/9=[fontconfig,harfbuzz] required by (media-video/mpv-0.32.0-r1:0/0::gentoo, installed) USE="X alsa bluray cdda cli dvd egl iconv javascript jpeg lcms libass lua luajit opengl uchardet vdpau xv zlib (-aqua) -archive (-coreaudio) -cplugins -cuda -debug -doc -drm -dvb -gamepad -gbm -jack -libcaca -libmpv -openal -oss -pulseaudio (-raspberry-pi) -rubberband -samba -sdl (-selinux) -test -tools -vaapi -vulkan -wayland -zimg" ABI_X86="(64)" PYTHON_TARGETS="python3_7 python3_8 -python3_6"
                                               ^^^^^^^^
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-11-20 17:49:41 UTC
Out of interest: anything change if you emerge -v1 mpv?
Comment 4 Daniel Pouzzner 2020-11-20 17:59:19 UTC
Bingo, the problem was this the update to the ebuild without a bump in the ebuild version:


--- /.mirrorsnaps/rootsnap.2020-11-20T12:00:01Z/usr/portage/media-video/mpv/mpv-0.32.0-r1.ebuild        2020-08-20 05:09:21.000000000 -0500
+++ /usr/portage/media-video/mpv/mpv-0.32.0-r1.ebuild   2020-11-19 23:39:11.000000000 -0600
@@ -82,7 +82,7 @@ COMMON_DEPEND="
        jpeg? ( virtual/jpeg:0 )
        lcms? ( >=media-libs/lcms-2.6:2 )
        libass? (
-               >=media-libs/libass-0.12.1:=[fontconfig,harfbuzz]
+               >=media-libs/libass-0.12.1:=[fontconfig,harfbuzz(+)]
                virtual/ttf-fonts
        )
        libcaca? ( >=media-libs/libcaca-0.99_beta18 )




Following your advice, I advanced to this:


# emerge --ask --oneshot --update --rebuild-if-new-slot --rebuild-if-new-rev --rebuild-if-new-ver --changed-use --newuse media-libs/libass

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild     U ~] media-libs/libass-0.15.0 [0.14.0]
[ebuild  rR   ~] media-video/mplayer-1.4-r1 
[ebuild  rR    ] media-video/mpv-0.32.0-r1 


Which completed successfully.

Thanks for the hint!
Comment 5 Larry the Git Cow gentoo-dev 2020-11-20 18:02:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=771c79d318c46f3c88b39e3cc69a6516c0491d00

commit 771c79d318c46f3c88b39e3cc69a6516c0491d00
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2020-11-20 18:02:24 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-11-20 18:02:39 +0000

    media-video/mpv: revbump for libass dep change
    
    The one time I don't revbump! What was I thinking?
    
    Fixes: 1d79551f66ff6e65b64d87a2060e546029d39ed8
    Closes: https://bugs.gentoo.org/755857
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Sam James <sam@gentoo.org>

 media-video/mpv/{mpv-0.32.0-r1.ebuild => mpv-0.32.0-r2.ebuild} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)