Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 755680 - net-vpn/openvpn-2.5.0 version bump
Summary: net-vpn/openvpn-2.5.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Patrick McLean
URL: https://openvpn.net/community-downloads/
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2020-11-20 10:40 UTC by Antonio Quartulli
Modified: 2020-11-25 21:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
new ebuild (openvpn-2.5.0.ebuild,3.91 KB, text/plain)
2020-11-20 10:41 UTC, Antonio Quartulli
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Quartulli 2020-11-20 10:40:28 UTC
Requesting a version bump of net-vpn/openvpn to version 2.5.0.

net-tools support has been dropped, default is using netlink.
--disable-crypto has been removed.

Reproducible: Always
Comment 1 Antonio Quartulli 2020-11-20 10:41:01 UTC
Created attachment 673369 [details]
new ebuild
Comment 2 Patrick McLean gentoo-dev 2020-11-25 06:46:01 UTC
Fixed.
Comment 3 Antonio Quartulli 2020-11-25 09:14:03 UTC
There is actually an issue with this ebuild.

OpenVPN-2.5.0 apparently has a bug which prevents the install scipt from copying the manpage at the right place in the system.

This bug can be described as:
"if there are no py-docutils installed (or found), openvpn does not install the manpage, even if the openvpn.8 file is readily available".

There are 2 options to move forward:
1) have the ebuild copy the manpage at the right place
2) apply commit bbac1542cfb4a9d3033999b26813f0dd0618c3f0 from the openvpn repo (currently staged for inclusion in 2.5.1)

(Adding a dependency on py-docutils does not make sense because, it is not really needed. This is a bug in the install script)
Comment 4 Jouni Kosonen 2020-11-25 17:01:19 UTC
(In reply to Antonio Quartulli from comment #3)
> There is actually an issue with this ebuild.
> 
> OpenVPN-2.5.0 apparently has a bug which prevents the install scipt from
> copying the manpage at the right place in the system.
> 
> This bug can be described as:
> "if there are no py-docutils installed (or found), openvpn does not install
> the manpage, even if the openvpn.8 file is readily available".
> 
> There are 2 options to move forward:
> 1) have the ebuild copy the manpage at the right place
> 2) apply commit bbac1542cfb4a9d3033999b26813f0dd0618c3f0 from the openvpn
> repo (currently staged for inclusion in 2.5.1)
> 
> (Adding a dependency on py-docutils does not make sense because, it is not
> really needed. This is a bug in the install script)

Does that actually work for you? The tarball comes with doc/openvpn.8.rst but no openvpn.8 so even with patching there's no manpage to install without py-docutils being found and used. At least for me this makes the ebuild fail in the install phase.

I can get the patched build to complete if I seed the environment with 
RST2MAN=/usr/bin/rst2man.py 
(so that it finds the binary, it doesn't expect the .py) and also 
RST2HTML=/usr/bin/rst2html.py 
(so that it accepts I have the py-docutils installed and uses them.)

Those both come from dev-python/docutils.

Then again, I'm not seeing any bugs posted about build failures so this might be something local to my machine.
Comment 5 Gert Doering 2020-11-25 17:11:53 UTC
Hi,

which tarball are you using, with which md5 sum?

I checked the tarballs from https://openvpn.net/community-downloads-2/ with the following md5 sums ("openssl md5 ...")

MD5(openvpn-2.5.0.tar.xz)= ba426e2217833b522810d6c06f7cc8f7
MD5(openvpn-2.5.0.tar.gz)= 2d42d3c2fff942bfe9eefa41cfd6f123

and they both contain the openvpn.8


$ tar tvfJ openvpn-2.5.0.tar.xz |grep openvpn.8
-rw-rw-r-- 1000/1000    252258 2020-10-28 08:25 openvpn-2.5.0/doc/openvpn.8
-rw-rw-r-- 1000/1000      4203 2020-10-28 08:25 openvpn-2.5.0/doc/openvpn.8.rst
-rw-rw-r-- 1000/1000    361268 2020-10-28 08:25 openvpn-2.5.0/doc/openvpn.8.html

so, obviously "something went wrong", we need to find and fix it.

gert
Comment 6 Gert Doering 2020-11-25 17:29:17 UTC
OK, so it turns out the tarballs from github are broken, and the ebuild fetches from there.  Not sure why it does that - the official repo for the releases is not github, but either of

https://build.openvpn.net/downloads/releases/${P}.tar.gz
https://swupdate.openvpn.org/community/releases/{$P}.tar.gz

and they both also have a detached GPG sig (.asc) which validates correctly.


Now *why* there are incomplete ("built on a machine without py-docutils") tarballs on github is something for us (OpenVPN upstream) to investigate.
Comment 7 Larry the Git Cow gentoo-dev 2020-11-25 19:18:36 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f119185766e42ad104fe5da7338612c7ea6f4ddd

commit f119185766e42ad104fe5da7338612c7ea6f4ddd
Author:     Patrick McLean <patrick.mclean@sony.com>
AuthorDate: 2020-11-25 19:18:05 +0000
Commit:     Patrick McLean <chutzpah@gentoo.org>
CommitDate: 2020-11-25 19:18:29 +0000

    net-vpn/openvpn-2.5.0-r1: revbump, use alternate tarball (bug #755680)
    
    Bug: https://bugs.gentoo.org/755680
    Copyright: Sony Interactive Entertainment Inc.
    Package-Manager: Portage-3.0.10, Repoman-3.0.2
    Signed-off-by: Patrick McLean <chutzpah@gentoo.org>

 net-vpn/openvpn/Manifest                                         | 2 +-
 .../openvpn/{openvpn-2.5.0.ebuild => openvpn-2.5.0-r1.ebuild}    | 9 ++++++---
 2 files changed, 7 insertions(+), 4 deletions(-)
Comment 8 jospezial 2020-11-25 20:34:29 UTC
Copyright: Sony Interactive Entertainment Inc.
Wtf? Why?
Comment 9 Kobboi 2020-11-25 21:22:41 UTC
Also: why did the + in +openssl get dropped?
Comment 10 Patrick McLean gentoo-dev 2020-11-25 21:34:15 UTC
(In reply to jospezial from comment #8)
> Copyright: Sony Interactive Entertainment Inc.
> Wtf? Why?

Because that is my employer and I am doing Gentoo work during work hours. The ::gentoo tree copyrights are owned by whoever does the work (like the Linux kernel).

Contributing to Gentoo on work time is officially authorized by my employer, and all the work is being contributed under the GPL license.