Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 755587 - sys-kernel/genkernel initramfs support for --perf-no_read_workqueue nad --perf-no_write_workqueue flags
Summary: sys-kernel/genkernel initramfs support for --perf-no_read_workqueue nad --per...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2020-11-19 17:04 UTC by Vladi
Modified: 2021-03-21 23:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladi 2020-11-19 17:04:16 UTC
Support for flags added in cryptsetup 2.3.4 that improver luks performance on nvme drives.


Reproducible: Always
Comment 1 Vladi 2020-11-19 17:05:15 UTC
Bypass dm-crypt internal workqueue and process read or write requests synchronously.  This option is only relevant for open action.
NOTE:  These options are available only for low-level dm-crypt performance tuning, use only if you need a change to default dm-crypt behaviour. Needs kernel 5.9 or later.

Similar to the allow discards implementation.
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2021-02-07 18:03:40 UTC
I'll not implement those options. Instead we will provide new generic options for additional options to pass to cryptsetup.
Comment 3 Thomas Deutschmann (RETIRED) gentoo-dev 2021-02-07 18:04:35 UTC
And the recommended way is to use LUKS2 and make these flags permanent.
Comment 4 Larry the Git Cow gentoo-dev 2021-02-07 18:23:01 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/genkernel.git/commit/?id=a0a6d6313874a7567a26c405713aaf610695285d

commit a0a6d6313874a7567a26c405713aaf610695285d
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2021-02-07 18:02:29 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2021-02-07 18:02:29 +0000

    linuxrc: add kernel command-line argument to allow user to pass additional options to cryptsetup
    
    Cryptsetup supports additional options like "--perf-no_read_workqueue" or
    "--perf-no_write_workqueue". While it is recommended to use LUKS2 format
    and make these activiation flags permanent, you can also make use of
    the new kernel command-line arguments "crypt_root_options" for root device
    or "crypt_swap_options" for swap device to pass additional options
    to cryptsetup.
    
    These arguments can be specified multiple times or separate multiple
    options with a comma.
    
    Bug: https://bugs.gentoo.org/755587
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 defaults/initrd.defaults |  2 ++
 defaults/initrd.scripts  | 16 +++++++---------
 defaults/linuxrc         | 13 ++++++++++++-
 defaults/unlock-luks.sh  |  8 +++-----
 doc/genkernel.8.txt      | 10 ++++++++++
 5 files changed, 34 insertions(+), 15 deletions(-)
Comment 5 Thomas Deutschmann (RETIRED) gentoo-dev 2021-03-21 23:22:50 UTC
Released with genkernel-4.2.0!