Bug 754966 – media-libs/opencolorio-1.1.1: stabilisation

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sam James 2020-11-16 19:38:06 UTC]

Fixes build with newer media-libs/openimageio.

[Comment 1 Kenton Groombridge 2020-11-16 20:27:57 UTC]

Not sure where to post this, but on one of my clang boxes, 1.1.1 failed to build with this error:

/var/tmp/portage/media-libs/opencolorio-1.1.1/work/OpenColorIO-1.1.1/src/core/Config.cpp:333:35: error: assigning field to itself [-Werror,-Wself-assign-field]

The following patch fixed the build.

[Comment 2 Kenton Groombridge 2020-11-16 20:28:30 UTC]

Created attachment 671680 [details, diff]
opencolorio-1.1.1-config-fix-self-assignment.patch

[Comment 3 Sam James 2020-11-16 20:39:40 UTC]

(In reply to 0xC0ncord from comment #1)
> Not sure where to post this, but on one of my clang boxes, 1.1.1 failed to
> build with this error:
> 
> /var/tmp/portage/media-libs/opencolorio-1.1.1/work/OpenColorIO-1.1.1/src/
> core/Config.cpp:333:35: error: assigning field to itself
> [-Werror,-Wself-assign-field]
> 
> The following patch fixed the build.

Thanks!

Fixed upstream in https://github.com/AcademySoftwareFoundation/OpenColorIO/commit/0be465feb9ac2d34bd8171f30909b276c1efa996#diff-1c73f65d469e79d569e1189d6163165834fcdf608a5b70f374075f52ee356a34.

(Upstream bug: https://github.com/AcademySoftwareFoundation/OpenColorIO/issues/563).

Does the upstream patch work for you? It looks a bit more invasive so I guess I'm more inclined to go with yours.

Also, could you share the GCO sign off please? (Signed-off-by: Real Name <email>)

[Comment 4 Sam James 2020-11-17 00:02:19 UTC]

amd64 done

[Comment 5 Kenton Groombridge 2020-11-17 00:13:24 UTC]

(In reply to Sam James from comment #3)
> Does the upstream patch work for you? It looks a bit more invasive so I
> guess I'm more inclined to go with yours.

It seems like that patch needs some reworking to get to apply cleanly to 1.1.1, since many path names were changed since that commit.

> Also, could you share the GCO sign off please? (Signed-off-by: Real Name
> <email>)

Sorry about that!

(Signed-off-by: 0xC0ncord <[e-mail]>)

[Comment 6 Agostino Sarubbo 2020-11-17 19:19:34 UTC]

x86 stable. Closing.

[Comment 7 Larry the Git Cow 2020-11-18 19:21:04 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=175603a404585a7e5c045c4bab7982b617bec5cd

commit 175603a404585a7e5c045c4bab7982b617bec5cd
Author:     Sam James <[e-mail]>
AuthorDate: 2020-11-18 19:20:55 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2020-11-18 19:21:00 +0000

    media-libs/opencolorio: fix Clang build
    
    Thanks-to: 0xC0ncord <[e-mail]>
    Bug: https://bugs.gentoo.org/754966
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Sam James <[e-mail]>

 .../files/opencolorio-1.1.1-fix-self-assign-clang.patch    | 14 ++++++++++++++
 media-libs/opencolorio/opencolorio-1.1.1.ebuild            |  1 +
 2 files changed, 15 insertions(+)

[Comment 8 Sam James 2020-11-18 19:21:24 UTC]

(In reply to 0xC0ncord from comment #5)
> (In reply to Sam James from comment #3)
> > Does the upstream patch work for you? It looks a bit more invasive so I
> > guess I'm more inclined to go with yours.
> 
> It seems like that patch needs some reworking to get to apply cleanly to
> 1.1.1, since many path names were changed since that commit.
> 
> > Also, could you share the GCO sign off please? (Signed-off-by: Real Name
> > <email>)
> 
> Sorry about that!
> 
> (Signed-off-by: 0xC0ncord <[e-mail]>)

I have a feeling that might not be your real name, but it's a simple enough change (and the only possible fix), so it's fine ;)