Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 754318 - dev-lang/lua: bump to 5.4.1 (SLOT=5.4) and 5.3.6 (SLOT=5.3)
Summary: dev-lang/lua: bump to 5.4.1 (SLOT=5.4) and 5.3.6 (SLOT=5.3)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-14 00:04 UTC by Marek Szuba
Modified: 2020-11-16 14:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
lua-5.4.1.ebuild (lua-5.4.1.ebuild,5.56 KB, text/plain)
2020-11-14 00:04 UTC, Marek Szuba
Details
lua-5.4-make-r1.patch (lua-5.4-make-r1.patch,2.55 KB, patch)
2020-11-14 00:05 UTC, Marek Szuba
Details | Diff
lua-5.3.6.ebuild (lua-5.3.6.ebuild,5.59 KB, text/plain)
2020-11-14 00:24 UTC, Marek Szuba
Details
lua-5.3-make-r2.patch (lua-5.3-make-r2.patch,2.50 KB, patch)
2020-11-14 00:25 UTC, Marek Szuba
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba archtester gentoo-dev 2020-11-14 00:04:08 UTC
Seeing as many people are now working on migrating packages to lua{,-single}.eclass, perhaps we could already have lua-5.4 in the tree so that it can be added to LUA_COMPAT where appropriate at the same time? Especially given it turns out 5.4.1 builds and tests fine with pretty much the same set-up as 5.3.5, it took me more time to migrate to EAPI-7 than it took to bump the version.

Attaching both an updated ebuild and the relevant Makefile patch. Note that the former *does* include the "apply upstream patches from a subdirectory of FILESDIR" functionality, even though it is only actually used by very few Lua ebuilds and some of the more recent ones do not even try.
Comment 1 Marek Szuba archtester gentoo-dev 2020-11-14 00:04:36 UTC
Created attachment 671275 [details]
lua-5.4.1.ebuild
Comment 2 Marek Szuba archtester gentoo-dev 2020-11-14 00:05:13 UTC
Created attachment 671278 [details, diff]
lua-5.4-make-r1.patch
Comment 3 Marek Szuba archtester gentoo-dev 2020-11-14 00:08:25 UTC
PS. Remember to mask dev-lang/lua:5.4 as well for now, I don't think we have got a mask for this slot/version yet.
Comment 4 Marek Szuba archtester gentoo-dev 2020-11-14 00:24:49 UTC
Created attachment 671281 [details]
lua-5.3.6.ebuild

And while at it - here is an EAPI-7 ebuild (complete with updated makefile patch) for lua-5.3.6, which according to lua.org will likely be the last Lua 5.3 release.

Come to think of it, for consistency the 5.4 makefile patch should probably be renamed to -r2 for consistency.
Comment 5 Marek Szuba archtester gentoo-dev 2020-11-14 00:25:05 UTC
Created attachment 671284 [details, diff]
lua-5.3-make-r2.patch
Comment 6 Larry the Git Cow gentoo-dev 2020-11-14 01:17:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=710464016e80e466066e880f8e8a449037ed6f33

commit 710464016e80e466066e880f8e8a449037ed6f33
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2020-11-14 01:15:16 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2020-11-14 01:17:02 +0000

    dev-lang/lua: 5.3.6 bump
    
    Signed-off-by: William Hubbs <williamh@gentoo.org>
    
    Bug: https://bugs.gentoo.org/754318

 dev-lang/lua/Manifest         |   1 +
 dev-lang/lua/lua-5.3.6.ebuild | 194 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 195 insertions(+)
Comment 7 Larry the Git Cow gentoo-dev 2020-11-16 14:34:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=48e616adccbebbdf28baa025ae832c5e17f99c65

commit 48e616adccbebbdf28baa025ae832c5e17f99c65
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2020-11-16 14:31:19 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2020-11-16 14:31:19 +0000

    dev-lang/lua: 5.4.1 bump
    
    Closes: https://bugs.gentoo.org/754318
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 dev-lang/lua/Manifest                      |   2 +
 dev-lang/lua/files/lua-5.4-makefiles.patch |  99 ++++++++++++++
 dev-lang/lua/lua-5.4.1.ebuild              | 200 +++++++++++++++++++++++++++++
 3 files changed, 301 insertions(+)