Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 753914 - x11-drivers/nvidia-drivers depends on gdk-pixbuf[X]
Summary: x11-drivers/nvidia-drivers depends on gdk-pixbuf[X]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: David Seifert
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 534330
  Show dependency tree
 
Reported: 2020-11-10 18:47 UTC by Matt Turner
Modified: 2020-11-18 19:06 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-x11-drivers-nvidia-drivers-remove-unused-X-from-gdk-.patch (0001-x11-drivers-nvidia-drivers-remove-unused-X-from-gdk-.patch,4.04 KB, patch)
2020-11-10 19:02 UTC, Ionen Wolkens
Details | Diff
nvidia-drivers-revbumps-to-adjust-gdk-pixbuf-dep.patch (nvidia-drivers-revbumps-to-adjust-gdk-pixbuf-dep.patch,6.05 KB, patch)
2020-11-11 10:18 UTC, Ionen Wolkens
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2020-11-10 18:47:49 UTC
I only checked the 455 drivers, but I didn't see any shared objects or binaries linking with gdk-pixbuf-xlib.

Probably the dep is just ancient?
Comment 1 Ionen Wolkens gentoo-dev 2020-11-10 19:02:53 UTC
Created attachment 670796 [details, diff]
0001-x11-drivers-nvidia-drivers-remove-unused-X-from-gdk-.patch

I was testing those just now, I can confirm 390.xx to 455.xx (with USE=tools) all work fine with new gdk-pixbuf.

The only reference to gdk-pixbuf is actually an include in the gtk2 version of nvidia-settings, and it's not gdk-pixbuf-xlib.

Whole dep is questionable but it looks safe to just remove the [X] for now.
Comment 2 Ionen Wolkens gentoo-dev 2020-11-10 19:13:41 UTC
And err, guess need to revbump too, nevermind the patch :)
Comment 3 Ionen Wolkens gentoo-dev 2020-11-11 10:18:55 UTC
Created attachment 670903 [details, diff]
nvidia-drivers-revbumps-to-adjust-gdk-pixbuf-dep.patch

Had a closer look to be sure, no calls to gdk_pixbuf_xlib* nor xlib_* on any in-tree versions. At run time nvidia-settings loads one of libnvidia-gtk{2,3}.so and only linked with normal gdk-pixbuf.

Updating patch anyway (if wanted), given m-n for now I'd appreciate if someone took care of this regardless.

I've built all versions of the resulting ebuilds again against gdk-pixbuf-2.42.0 without issues on ~amd64, nvidia-settings runs fine both in gtk2 and gtk3 mode.
Comment 4 Ionen Wolkens gentoo-dev 2020-11-12 12:34:13 UTC
(In reply to Ionen Wolkens from comment #3)
> given m-n for now I'd appreciate if someone took care of this regardless.
Or actually, it just got picked up so let's leave that up to them :)

Good luck with that mess of ebuilds in general, would be simpler if nvidia-settings was split again.
Comment 5 Larry the Git Cow gentoo-dev 2020-11-18 18:26:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6158cd122253e1e75132083031e72cd8158f0bd4

commit 6158cd122253e1e75132083031e72cd8158f0bd4
Author:     Ionen Wolkens <sudinave@gmail.com>
AuthorDate: 2020-11-18 18:26:09 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-11-18 18:26:09 +0000

    x11-drivers/nvidia-drivers: revbumps to adjust gdk-pixbuf dep
    
    gdk-pixbuf-xlib wasn't used by nvidia-settings, so [X] can safely be removed.
    
    Closes: https://bugs.gentoo.org/753914
    Signed-off-by: Ionen Wolkens <sudinave@gmail.com>
    Signed-off-by: David Seifert <soap@gentoo.org>

 ...vidia-drivers-390.132-r4.ebuild => nvidia-drivers-390.132-r5.ebuild} | 2 +-
 ...vidia-drivers-390.138-r4.ebuild => nvidia-drivers-390.138-r5.ebuild} | 2 +-
 ...{nvidia-drivers-435.21-r6.ebuild => nvidia-drivers-435.21-r7.ebuild} | 2 +-
 ...vidia-drivers-440.100-r2.ebuild => nvidia-drivers-440.100-r3.ebuild} | 2 +-
 ...idia-drivers-450.80.02.ebuild => nvidia-drivers-450.80.02-r1.ebuild} | 2 +-
 .../{nvidia-drivers-455.28.ebuild => nvidia-drivers-455.28-r1.ebuild}   | 2 +-
 .../{nvidia-drivers-455.38.ebuild => nvidia-drivers-455.38-r1.ebuild}   | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)