Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 753908 - x11-misc/fbpanel depends on gdk-pixbuf[X]
Summary: x11-misc/fbpanel depends on gdk-pixbuf[X]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Desktop Misc. Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 534330
  Show dependency tree
 
Reported: 2020-11-10 18:27 UTC by Matt Turner
Modified: 2020-11-11 20:29 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fbpanel-7.0-remove-gtk-pixbuf-xlib.patch (fbpanel-7.0-remove-gtk-pixbuf-xlib.patch,819 bytes, patch)
2020-11-10 18:50 UTC, Ionen Wolkens
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2020-11-10 18:27:34 UTC
> plugin.c:5:10: fatal error: gdk-pixbuf-xlib/gdk-pixbuf-xlib.h: No such file or directory
>     5 | #include <gdk-pixbuf-xlib/gdk-pixbuf-xlib.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.

gdk-pixbuf-xlib was removed in v2.42.0.
Comment 1 Ionen Wolkens gentoo-dev 2020-11-10 18:50:01 UTC
Created attachment 670793 [details, diff]
fbpanel-7.0-remove-gtk-pixbuf-xlib.patch

Looks like gdk-pixbuf-xlib isn't "actually" needed, so it's just about removing the pointless includes.

Built against x11-libs/gdk-pixbuf-2.42.0 and gave it a quick try, seems fine.
Comment 2 Larry the Git Cow gentoo-dev 2020-11-11 19:14:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=89f767ce51e8550a8dd8e88959f4b74d4d1ad6da

commit 89f767ce51e8550a8dd8e88959f4b74d4d1ad6da
Author:     Ionen Wolkens <sudinave@gmail.com>
AuthorDate: 2020-11-11 19:13:42 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2020-11-11 19:14:30 +0000

    x11-misc/fbpanel: Remove unnecessary gdk-pixbuf-xlib.h includes
    
    Closes: https://bugs.gentoo.org/753908
    Signed-off-by: Ionen Wolkens <sudinave@gmail.com>
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 x11-misc/fbpanel/fbpanel-7.0-r2.ebuild             |  1 +
 .../fbpanel-7.0-remove-gdk-pixbuf-xlib.h.patch     | 26 ++++++++++++++++++++++
 2 files changed, 27 insertions(+)
Comment 3 Matt Turner gentoo-dev 2020-11-11 19:15:31 UTC
Nice, thanks a bunch!
Comment 4 Ionen Wolkens gentoo-dev 2020-11-11 20:20:05 UTC
Seems missed removing the now pointless [X] from the dep at same time.
Comment 5 Matt Turner gentoo-dev 2020-11-11 20:29:03 UTC
Oops! Thanks for catching that.
Comment 6 Larry the Git Cow gentoo-dev 2020-11-11 20:29:38 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d7e68203a37e287583277c26636cb6796beb73aa

commit d7e68203a37e287583277c26636cb6796beb73aa
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2020-11-11 20:28:08 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2020-11-11 20:29:30 +0000

    x11-misc/fbpanel: Remove USE=X gdk-pixbuf dependency
    
    This was my fault.
    
    Bug: https://bugs.gentoo.org/753908
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 x11-misc/fbpanel/fbpanel-7.0-r2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)