Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 753746 - net-misc/rsync-3.2.3-r1 - use upstream supplied systemd unit
Summary: net-misc/rsync-3.2.3-r1 - use upstream supplied systemd unit
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-09 17:24 UTC by Ben Kohler
Modified: 2021-03-07 11:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Kohler gentoo-dev 2020-11-09 17:24:53 UTC
Upstream tarball provides ./packaging/systemd/rsync.service which seems to be better than ours.

Among other things we have a warning in dmesg:
[489132.426316] systemd[1]: /lib/systemd/system/rsyncd.service:9: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether

One slight hiccup is that it's named rsync.service instead of our name, but I would suggest that we move to the new name to be consistent with other distros & upstream.

We dealt with a very similar issue in samba, moving to upstream units and slightly new naming, we used symlinks to preserve existing systems' functionality.

Can we move to the new rsync.service file?

Thanks!
Comment 1 Thomas Deutschmann (RETIRED) gentoo-dev 2020-11-09 20:05:52 UTC
Fedora/RHEL, OpenSuSE/SLES are using rsyncd.service.
Debian and Ubuntu are using rsync.service.

And if we really decide to change names, we should change it for both service managers.
Comment 2 Ben Kohler gentoo-dev 2020-11-10 14:40:56 UTC
That's fine, just skip the rename and start installing upstream's rsync.service to rsyncd.service
Comment 3 Larry the Git Cow gentoo-dev 2021-03-07 11:09:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d6883f4f840307909cda19b327ed085d55bd615a

commit d6883f4f840307909cda19b327ed085d55bd615a
Author:     Mikle Kolyada <zlogene@gentoo.org>
AuthorDate: 2021-03-07 11:08:36 +0000
Commit:     Mikle Kolyada <zlogene@gentoo.org>
CommitDate: 2021-03-07 11:08:36 +0000

    net-misc/rsync: use systemd unit from upstream
    
    Closes: https://bugs.gentoo.org/753746
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Mikle Kolyada <zlogene@gentoo.org>

 net-misc/rsync/{rsync-3.2.3-r1.ebuild => rsync-3.2.3-r2.ebuild} | 2 +-
 net-misc/rsync/rsync-9999.ebuild                                | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)