Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 753257 - dev-db/postgresql-13.0 w/ dev-libs/icu-68.1: collationcmds.c:467:51: error: ‘TRUE’ undeclared (first use in this function); did you mean ‘IS_TRUE’?
Summary: dev-db/postgresql-13.0 w/ dev-libs/icu-68.1: collationcmds.c:467:51: error: ‘...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PgSQL Bugs
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: icu-68.1
  Show dependency tree
 
Reported: 2020-11-06 00:24 UTC by Andreas Sturmlechner
Modified: 2020-11-28 14:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (dev-db:postgresql-13.0:20201106-001357.log,372.53 KB, text/x-log)
2020-11-06 00:24 UTC, Andreas Sturmlechner 		Details
Built successfully with this trivial patch (postgresql-13.0-icu68.patch,606 bytes, patch)
2020-11-07 05:12 UTC, Yury Katuar 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2020-11-06 00:24:16 UTC 
Created attachment 670112 [details]
build.log

The usual error caused by ICU removal of public macro definitions for TRUE and FALSE.
Comment 1 Yury Katuar 2020-11-07 05:12:35 UTC 
Created attachment 670295 [details, diff]
Built successfully with this trivial patch
Comment 2 Andreas Sturmlechner gentoo-dev 2020-11-11 19:01:52 UTC 
Works for me with 12/13.
Comment 3 Aaron W. Swenson gentoo-dev 2020-11-14 12:31:11 UTC 
(In reply to Nexion Kind from comment #1)
> Created attachment 670295 [details, diff] [details, diff]
> Built successfully with this trivial patch

Have you submitted this patch upstream?
Comment 4 Larry the Git Cow gentoo-dev 2020-11-14 13:59:31 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=734742ccd7c2a901d5fb30975c0c7d27c6482cc2

commit 734742ccd7c2a901d5fb30975c0c7d27c6482cc2
Author:     Aaron W. Swenson <titanofold@gentoo.org>
AuthorDate: 2020-11-14 13:50:18 +0000
Commit:     Aaron W. Swenson <titanofold@gentoo.org>
CommitDate: 2020-11-14 13:59:10 +0000

    dev-db/postgresql: Version Bumps
    
    Bump to:
     - 13.1
     - 12.5
     - 11.10
     - 10.15
     - 9.6.20
     - 9.5.24
    
    Fixes CVE-2020-25695, CVE-2020-25694, and CVE-2020-25696.
    
    Pg 10+ includes a patch to fix building wit ICU 68.
    
    Bug: https://bugs.gentoo.org/753257
    Bug: https://bugs.gentoo.org/754363
    
    Signed-off-by: Aaron W. Swenson <titanofold@gentoo.org>

 dev-db/postgresql/Manifest                         |   6 +
 .../postgresql/files/postgresql-10.0-icu68.patch   |  12 +
 dev-db/postgresql/postgresql-10.15.ebuild          | 459 ++++++++++++++++++++
 dev-db/postgresql/postgresql-11.10.ebuild          | 461 ++++++++++++++++++++
 dev-db/postgresql/postgresql-12.5.ebuild           | 461 ++++++++++++++++++++
 dev-db/postgresql/postgresql-13.1.ebuild           | 465 ++++++++++++++++++++
 dev-db/postgresql/postgresql-9.5.24.ebuild         | 476 ++++++++++++++++++++
 dev-db/postgresql/postgresql-9.6.20.ebuild         | 481 +++++++++++++++++++++
 dev-db/postgresql/postgresql-9999.ebuild           |   5 +
 9 files changed, 2826 insertions(+)
Comment 5 Andreas Sturmlechner gentoo-dev 2020-11-28 14:17:43 UTC 
I guess this bug can be closed then.