Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 752729 - games-strategy/widelands: migrate to lua eclasses
Summary: games-strategy/widelands: migrate to lua eclasses
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: slotted-lua
  Show dependency tree
 
Reported: 2020-11-03 15:36 UTC by Marek Szuba
Modified: 2020-12-02 23:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba archtester gentoo-dev 2020-11-03 15:36:54 UTC
In order for Gentoo Linux to properly support side-by-side installation of
different versions of Lua (including LuaJIT), please migrate this package as
to lua.eclass (for packages which should support multiple Lua implementations
at the same time, i.e. most likely Lua modules) or lua-single.eclass (for
packages which only have to support one Lua implementation at a time). For
details, consult documentation of respective eclasses as well as
already-migrated ebuilds in the tree.

Please note that since slotted dev-lang/lua is currently masked, your
migrated ebuilds should be masked as well. There is a section of package.mask,
created in September 2020, which you can use for this purpose so that it will
be easier in the future to unmask them all in one go.

Thank you in advance for your effort!
Comment 1 Larry the Git Cow gentoo-dev 2020-12-02 23:08:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c3b5eb39349d14067bcce3f3bb9398f90fbb2373

commit c3b5eb39349d14067bcce3f3bb9398f90fbb2373
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2020-12-02 22:54:29 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2020-12-02 23:08:13 +0000

    games-strategy/widelands: Do not depend on dev-lang/lua
    
    Short version: this package builds, tests and installs without any
    errors on systems without any versions of Lua installed, and even when a
    copy of Lua *is* installed does not interact with it in any way (which
    was already reflected by the fact dev-lang/lua was not mentioned in
    RDEPEND, only in DEPEND).
    
    Details:
    
    Widelands source code comes bundled with Lua - or to be precise with
    Eris (https://github.com/fnuecke/eris), which according to its upstream
    should be considered "a custom 'distribution' of Lua" due to the fact it
    hooks heavily into Lua internals. Since src/third_party/eris/README.eris
    explicitly states that the bundled Eris is what brings in the Lua
    version used in Widelands, it is no surprise that upstream build scripts
    do not even attempt to look for system Lua.
    
    Bug: https://bugs.gentoo.org/752729
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 games-strategy/widelands/widelands-0.20-r1.ebuild | 1 -
 games-strategy/widelands/widelands-9999.ebuild    | 1 -
 2 files changed, 2 deletions(-)
Comment 2 Marek Szuba archtester gentoo-dev 2020-12-02 23:09:17 UTC
No dev-lang/lua{,jit} dependency => no need to use Lua eclasses.