Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 752711 - games-strategy/freeciv: migrate to lua eclasses
Summary: games-strategy/freeciv: migrate to lua eclasses
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 757873
  Show dependency tree
 
Reported: 2020-11-03 15:36 UTC by Marek Szuba
Modified: 2021-06-05 17:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba archtester gentoo-dev 2020-11-03 15:36:47 UTC
In order for Gentoo Linux to properly support side-by-side installation of
different versions of Lua (including LuaJIT), please migrate this package as
to lua.eclass (for packages which should support multiple Lua implementations
at the same time, i.e. most likely Lua modules) or lua-single.eclass (for
packages which only have to support one Lua implementation at a time). For
details, consult documentation of respective eclasses as well as
already-migrated ebuilds in the tree.

Please note that since slotted dev-lang/lua is currently masked, your
migrated ebuilds should be masked as well. There is a section of package.mask,
created in September 2020, which you can use for this purpose so that it will
be easier in the future to unmask them all in one go.

Thank you in advance for your effort!
Comment 1 Marek Szuba archtester gentoo-dev 2020-12-01 12:36:23 UTC
USE=system-lua is masked for this package (it is not compatible with lua-5.1) so while it will eventually have to be migrated to the correct eclass, it does not block the migration to slotted Lua. Resolving this as NEEDINFO as a substitute for LATER, same as with other packages in the same situation.
Comment 2 Larry the Git Cow gentoo-dev 2021-06-05 17:48:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=520793f9e323a38d14456e058d69c539735e2f9d

commit 520793f9e323a38d14456e058d69c539735e2f9d
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2021-06-05 17:45:29 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2021-06-05 17:48:06 +0000

    games-strategy/freeciv: migrate to lua-single.eclass
    
    Builds and installs fine against lua5-3. Against lua5-4, src_configure
    dies with
    "configure: error: Use of included lua disabled, and no lua found from system"
    
    Note: USE=system-lua is still masked for this package, leaving it up to
    its maintainers to unmask it.
    
    Closes: https://bugs.gentoo.org/752711
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 games-strategy/freeciv/freeciv-2.6.4.ebuild | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)