Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 752546 - app-eselect/eselect-lua: remove the PDEPEND block
Summary: app-eselect/eselect-lua: remove the PDEPEND block
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Vadim A. Misbakh-Soloviov (mva)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-03 15:35 UTC by Marek Szuba
Modified: 2020-12-06 15:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba archtester gentoo-dev 2020-11-03 15:35:39 UTC
In order for Gentoo Linux to properly support side-by-side installation of
different versions of Lua (including LuaJIT), please migrate this package as
to lua.eclass (for packages which should support multiple Lua implementations
at the same time, i.e. most likely Lua modules) or lua-single.eclass (for
packages which only have to support one Lua implementation at a time). For
details, consult documentation of respective eclasses as well as
already-migrated ebuilds in the tree.

Please note that since slotted dev-lang/lua is currently masked, your
migrated ebuilds should be masked as well. There is a section of package.mask,
created in September 2020, which you can use for this purpose so that it will
be easier in the future to unmask them all in one go.

Thank you in advance for your effort!
Comment 1 Marek Szuba archtester gentoo-dev 2020-11-30 18:46:28 UTC
Oops, this shouldn't have been on this list. Sorry. Let me refactor this ticket into something we DO need of eselect-lua:

We have at long last got lua-5.4 in the tree, could you follow up on the TODO note in the ebuild and add that slot to PDEPEND?
Comment 2 Marek Szuba archtester gentoo-dev 2020-12-06 14:50:36 UTC
Yet another change: come to think of it, this package should simply not depend on any Lua implementation at all. All the dev-lang/lua slots (other than 0 of course) already depend on eselect-lua, said package does not in fact need any Lua implementation to function properly, it adds a level of indirection to adding new Lua implementations to the tree, and it might in fact be the only eselect module we have currently got in the tree (I stopped checking about halfway through) which actually depends on any implementations it lets the users select from. Last but not least, the LuaJIT alternative is not quite right because the symlinks for that implementation are handled by dev-lang/luajit itself.
Comment 3 Larry the Git Cow gentoo-dev 2020-12-06 15:03:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=007c50206d790f4593156fea91b372f76b04d337

commit 007c50206d790f4593156fea91b372f76b04d337
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2020-12-06 14:54:55 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2020-12-06 15:03:02 +0000

    app-eselect/eselect-lua: do not PDEPEND on Lua implementations
    
    Does not actually depend on Lua, makes it necessary to have every new
    implementation added to the list, redundant (dev-lang/lua slots already
    depend on app-eselect/eselect-lua), inconsistent with how other "select
    your implementation" eselect modules handle dependencies, the LuaJIT
    alternative was not entirely correct.
    
    Closes: https://bugs.gentoo.org/752546
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 app-eselect/eselect-lua/eselect-lua-2.ebuild | 22 ++++------------------
 1 file changed, 4 insertions(+), 18 deletions(-)