Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 752426 - app-misc/no-more-secrets: ebuild enhancements
Summary: app-misc/no-more-secrets: ebuild enhancements
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Rick Farina (Zero_Chaos)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-11-03 06:03 UTC by Joonas Niilola
Modified: 2020-11-05 07:20 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Niilola gentoo-dev 2020-11-03 06:03:45 UTC
Hey, 

app-misc/no-more-secrets looks a bit dated. It could do an update. Here's what I suggest: 

 - bump to EAPI-7, 
 - make a keyworded release from tagged upstream release, 
 - fix QA issues in the ebuild: 
   - sed is called without "|| die",
   - sed is called 3 times to edit a single file.
Comment 1 Larry the Git Cow gentoo-dev 2020-11-05 07:20:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0bd94c6dc905a63e04a62202646c6093db6ef1cc

commit 0bd94c6dc905a63e04a62202646c6093db6ef1cc
Author:     Alessandro Barbieri <lssndrbarbieri@gmail.com>
AuthorDate: 2020-11-05 02:38:19 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-11-05 07:20:21 +0000

    app-misc/no-more-secrets: add tagged release 0.3.3
    
    Closes: https://bugs.gentoo.org/752426
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Alessandro Barbieri <lssndrbarbieri@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/18136
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-misc/no-more-secrets/Manifest                  |  1 +
 .../no-more-secrets/no-more-secrets-0.3.3.ebuild   | 30 ++++++++++++++++++++++
 2 files changed, 31 insertions(+)