Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 752162 - sys-apps/busybox[make-symlinks]: incorrectly tests for ${ROOT} == / despite EAPI 7
Summary: sys-apps/busybox[make-symlinks]: incorrectly tests for ${ROOT} == / despite E...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Embedded Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-01 21:42 UTC by Ionen Wolkens
Modified: 2020-11-02 11:42 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ionen Wolkens gentoo-dev 2020-11-01 21:42:22 UTC
When EAPI=7[0], ${ROOT} == "/" will always be false in:

	if use make-symlinks && [[ ! ${VERY_BRAVE_OR_VERY_DUMB} == "yes" ]] && [[ ${ROOT} == "/" ]] ; then

Thus prevents the safeguard from functioning.

Should be changed to [[ -z ${ROOT} ]]

Brought to my attention because of this thread:
https://forums.gentoo.org/viewtopic-t-1122635.html

[0] https://mgorny.pl/articles/the-ultimate-guide-to-eapi-7.html#d-ed-root-eroot-no-longer-have-a-trailing-slash
Comment 1 Larry the Git Cow gentoo-dev 2020-11-02 11:42:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=58414b6f079cd6e3134624c6b834f39b87d0a925

commit 58414b6f079cd6e3134624c6b834f39b87d0a925
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2020-11-02 11:41:06 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-11-02 11:42:06 +0000

    sys-apps/busybox: fix 'make-symlinks' safeguard
    
    Thanks-to: Ionen Wolkens <sudinave@gmail.com>
    Bug: https://bugs.gentoo.org/703936
    Closes: https://bugs.gentoo.org/752162
    Package-Manager: Portage-3.0.8, Repoman-3.0.2
    Signed-off-by: Sam James <sam@gentoo.org>

 .../busybox/{busybox-1.31.1-r2.ebuild => busybox-1.31.1-r3.ebuild}  | 2 +-
 .../busybox/{busybox-1.32.0.ebuild => busybox-1.32.0-r1.ebuild}     | 2 +-
 sys-apps/busybox/busybox-9999.ebuild                                | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)