Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 752057 - media-libs/libvpx: uses the wrong strip program
Summary: media-libs/libvpx: uses the wrong strip program
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-10-31 21:41 UTC by David Michael
Modified: 2020-11-01 16:03 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch (libvpx.patch,2.12 KB, patch)
2020-11-01 01:51 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff
Alternative path (libvpx-alternative.patch,1.05 KB, patch)
2020-11-01 10:33 UTC, Stephan Hartmann (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Michael 2020-10-31 21:41:06 UTC
The configure script understands the STRIP environment variable, which is not being provided.  As a result, it calls the native strip program which dumps a couple dozen lines of "unrecognized input" messages in the build output when cross-compiling.

Reproducible: Always

Steps to Reproduce:
1. cross-emerge -v libvpx

Actual Results:  
strip --strip-debug \
          -o libvp9rc.a libvp9rc_g.a
strip: Unable to recognise the format of the input file `libvp9rc_g.a(vp9_iface_common.c.o)'
strip: Unable to recognise the format of the input file `libvp9rc_g.a(vp9_alloccommon.c.o)'
strip: Unable to recognise the format of the input file `libvp9rc_g.a(vp9_blockd.c.o)'
strip: Unable to recognise the format of the input file `libvp9rc_g.a(vp9_entropy.c.o)'
strip: Unable to recognise the format of the input file `libvp9rc_g.a(vp9_entropymode.c.o)'
...

Expected Results:  
It should use the correct strip program (or maybe obey FEATURES=nostrip).

--- media-libs/libvpx/libvpx-1.9.0.ebuild
+++ media-libs/libvpx/libvpx-1.9.0.ebuild
@@ -87,7 +87,7 @@
 	[[ ${CHOST} == powerpc-* ]] && myconfargs+=( --force-target=generic-gnu )
 
 	# Build with correct toolchain.
-	tc-export CC CXX AR NM
+	tc-export CC CXX AR NM STRIP
 	# Link with gcc by default, the build system should override this if needed.
 	export LD="${CC}"
Comment 1 Arfrever Frehtes Taifersar Arahesis 2020-11-01 00:27:29 UTC
Build systems should NOT call any strip tool (either ${CHOST}-strip or llvm-strip).
Portage will call appropriate strip tool (respecting ${STRIP}) unless user disables it.
Comment 2 Arfrever Frehtes Taifersar Arahesis 2020-11-01 01:51:17 UTC
Created attachment 669509 [details, diff]
Patch
Comment 3 David Michael 2020-11-01 01:57:01 UTC
Works for me, thanks.
Comment 4 Stephan Hartmann (RETIRED) gentoo-dev 2020-11-01 10:33:05 UTC
Created attachment 669533 [details, diff]
Alternative path

Can you check if this patch works for you as well?
Comment 5 David Michael 2020-11-01 13:59:23 UTC
Yes, that seems to have the same effect.
Comment 6 Larry the Git Cow gentoo-dev 2020-11-01 16:03:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d7fb59cb2cd44b9e0b0eb50cc2f7491202e0a204

commit d7fb59cb2cd44b9e0b0eb50cc2f7491202e0a204
Author:     Stephan Hartmann <sultan@gentoo.org>
AuthorDate: 2020-11-01 16:01:20 +0000
Commit:     Stephan Hartmann <sultan@gentoo.org>
CommitDate: 2020-11-01 16:02:19 +0000

    media-libs/libvpx: disable stripping for static libraries
    
    Closes: https://bugs.gentoo.org/752057
    Package-Manager: Portage-3.0.8, Repoman-3.0.2
    Signed-off-by: Stephan Hartmann <sultan@gentoo.org>

 media-libs/libvpx/libvpx-1.9.0.ebuild | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)