Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 751898 - net-im/signal-desktop-bin-1.37.2 fails to patch .desktop entry: "!has_version: command not found"
Summary: net-im/signal-desktop-bin-1.37.2 fails to patch .desktop entry: "!has_version...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robert G. Siebeck
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-10-30 12:03 UTC by El Goretto
Modified: 2020-11-01 06:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description El Goretto 2020-10-30 12:03:11 UTC
Following Bug 747775, the new "sound" USE flag has been implemented (great idea), but seems to introduce some syntax issue in the ebuild, at the src_install() function level (I have no ebuild syntax mastery :)):

    if has_version media-sound/apulse[-sdk] && !has_version media-sound/pulseaudio; then
        sed -i 's/Exec=/Exec=apulse /g' usr/share/applications/signal-desktop.desktop
    fi



Reproducible: Always

Steps to Reproduce:
1.have media-sound/apulse[-sdk] (and no pulseaudio)
2.emerge signal-desktop-bin-1.37.2

Actual Results:  
In the emerge output: 
/var/tmp/portage/net-im/signal-desktop-bin-1.37.2/temp/environment: line 1379: !has_version: command not found

I can confirm .desktop entry is not patched with the apulse wrapper call.

Expected Results:  
No error output and .desktop entry is patched with the apulse wrapper call.
Comment 1 Larry the Git Cow gentoo-dev 2020-11-01 06:14:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0fcdd828a78423fdeb52b07585c20ed91bad74af

commit 0fcdd828a78423fdeb52b07585c20ed91bad74af
Author:     Robert Siebeck <gentoo.2019@r123.de>
AuthorDate: 2020-10-31 22:00:52 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-11-01 06:13:55 +0000

    net-im/signal-desktop-bin: add new version 1.37.2-r1
    
    Closes: https://bugs.gentoo.org/751898
    Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../signal-desktop-bin-1.37.2-r1.ebuild            | 115 +++++++++++++++++++++
 1 file changed, 115 insertions(+)