Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 751076 - lxde-base/lxsession-0.5.5 version bump
Summary: lxde-base/lxsession-0.5.5 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: EBUILD, PullRequest
Depends on:
Blocks:
 
Reported: 2020-10-25 00:25 UTC by jospezial
Modified: 2021-03-15 13:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
lxsession-0.5.5.ebuild with gtk3 enabled (lxsession-0.5.5.ebuild,1.14 KB, text/plain)
2020-10-25 00:54 UTC, jospezial
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jospezial 2020-10-25 00:25:04 UTC
"Posted on March 1, 2020 by LStranger
LXSession 0.5.5 released.

The time to update the LXDE main session manager has come. Again, no new features but bugs fixing, and some translations updates, of course. We all hope it’s better than previous one was.


Changes since previous release 0.5.4 (see git log for details):

    Remove libunique dependency, and use glib >= 2.28.0 to handle unique apps both for GTK+ 2 and 3.
    Fix possible memory issue: use memmove instead of memcpy for overlapping area copy.
    Fix memory issue: never free buffer returned by gtk_entry_get_text().
    Fix spelling error: assiociate -> associate.
    Pass desktop_environnement as a parameter for lxsession-xdg-autostart to fix wrong autostart processing.
    Replace “images_display” with “image_display” for consistency.
    Translations updates.
"
Comment 1 jospezial 2020-10-25 00:54:23 UTC
Created attachment 668366 [details]
lxsession-0.5.5.ebuild with gtk3 enabled

-SRC_URI="mirror://sourceforge/lxde/${P}.tar.xz"
+SRC_URI="https://github.com/lxde/${PN}/archive/${PV}.tar.gz -> ${P}.tar.gz"
The src archive files at sourceforge have autogenerated files which are not overwritten and break the compilation for GTK3 (GtkObject).
Arch linux does:
# Regenerate C sources from Vala code
  rm *.stamp
  autoreconf -fi



-	dev-libs/libunique:1
dependency is gone

-	x11-libs/gtk+:2
+	x11-libs/gtk+:3

 	"${FILESDIR}"/${PN}-0.5.2-reload.patch
 	"${FILESDIR}"/${PN}-0.5.2-notify-daemon-default.patch
-	"${FILESDIR}"/${PN}-0.5.2-fix-invalid-memcpy.patch
memcpy.patch is now in upstream code.
Don't know about the other two. They still apply.


-	# gtk3 looks to not be ready, follow what other distributions are
-	# doing
 	econf \
 		$(use_enable nls) \
-		--disable-gtk3
+		--enable-gtk3

Compile and run tested.


LXSession.................................... : Version 0.5.5

Prefix....................................... : /usr
Sysconfdir................................... : /etc
GTK support.................................. : yes
GTK Cliboard build-in suport................. : no
GTK Polkit-agent build-in suport............. : no
Enable GTK3 support.......................... : yes
Enable debug................................. : no
Man pages generation support................. : yes

The binary will be installed in /usr/bin

http://lxde.org/

Have fun!

>>> Source configured.
Comment 2 jospezial 2020-10-25 00:58:36 UTC
I am using clipit as GTK3 Clipboard.

x11-misc/clipit-9999::jorgicio was built with the following:
USE="gtk3 nls -appindicator" ABI_X86="(64)"
Comment 3 Jonas Stein gentoo-dev 2020-10-25 01:38:00 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas (mostly minor things):

* Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman and pkgcheck
* # Copyright 1999-2019 Gentoo Authors
https://devmanual.gentoo.org/ebuild-writing/eapi/)
* KEYWORDS need ~ after a version bump run ekeyword ~all YOUREBUILD
* were the fedora patches still not merged upstream?
* A bot can look for additional mistakes, if you upload a PR via github
Comment 4 jospezial 2020-11-11 21:21:47 UTC
All other lxde*/* ebuilds need to be converted from gtk2 to gtk3 to have it all work good together.
Would be nice to find a maintainer for this slowly developing project.
Maybe something happens when gtk4 is in public use in near future.
Comment 5 Larry the Git Cow gentoo-dev 2021-03-15 13:14:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6cd341bd1c46ae524dba91fca3cafa78ca64139f

commit 6cd341bd1c46ae524dba91fca3cafa78ca64139f
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-03-14 00:44:20 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-03-15 13:08:21 +0000

    lxde-base/lxsession: 0.5.5 version bump, switch to GTK3
    
    Add missing dependencies
    
    Closes: https://bugs.gentoo.org/751076
    Package-Manager: Portage-3.0.17, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 lxde-base/lxsession/Manifest               |  1 +
 lxde-base/lxsession/lxsession-0.5.5.ebuild | 61 ++++++++++++++++++++++++++++++
 2 files changed, 62 insertions(+)