Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 750941 - kde-apps/okular[chm]: Missing required dependency dev-libs/libzip
Summary: kde-apps/okular[chm]: Missing required dependency dev-libs/libzip
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-24 00:02 UTC by Michael
Modified: 2020-10-25 00:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael 2020-10-24 00:02:21 UTC
CHM plugin requires epub plugin, otherwise it doesn't build or install.
Comment 1 Andreas Sturmlechner gentoo-dev 2020-10-24 00:36:22 UTC
There's no evidence of that.
Comment 2 Michael 2020-10-24 02:56:12 UTC
okay, steps to reproduce:
1. emerge okular with USE="chm -epub"
2. open a chm file with it
Expected result: chm file opened
Actual result: "no plugin installed" error message
Comment 3 Andreas Sturmlechner gentoo-dev 2020-10-24 09:26:58 UTC
Could it be that you really are missing dev-libs/libzip in step 1?
Comment 4 Michael 2020-10-24 11:14:09 UTC
(In reply to Andreas Sturmlechner from comment #3)
> Could it be that you really are missing dev-libs/libzip in step 1?

That would be my guess, but nothing pulls it in. So, maybe okular USE="chm" should pull libzip in. 
I could experiment with emerging it by myself, to prove or disprove this theory.
Comment 5 Andreas Sturmlechner gentoo-dev 2020-10-24 19:15:38 UTC
(In reply to Michael from comment #4)
> That would be my guess, but nothing pulls it in. So, maybe okular USE="chm"
> should pull libzip in. 

That's my conclusing after looking at cmake.
Comment 6 Michael 2020-10-24 19:50:17 UTC
(In reply to Andreas Sturmlechner from comment #5)
> That's my conclusing after looking at cmake.

I think you are correct, and it makes a lot of sense that you need to be able to unzip CHM to view it. I'm just a little surprised that the build doesn't fail, it just silently skips the plugin. 

Anyhow. Do you need me to manually install libzip and build okular with USE="chm -epub" to confirm?
Comment 7 Andreas Sturmlechner gentoo-dev 2020-10-24 20:10:03 UTC
(In reply to Michael from comment #6)
> I'm just a little surprised that the build doesn't fail, it just silently
> skips the plugin.
That's what the check in generators/CMakeLists.txt does; add the subdir if dependencies were found.

(In reply to Michael from comment #6)
> Anyhow. Do you need me to manually install libzip and build okular with
> USE="chm -epub" to confirm?
Not necessary, thanks.
Comment 8 Larry the Git Cow gentoo-dev 2020-10-25 00:26:41 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=dfc36a12c97b9ba3b2be0e9f8358e10d6c6bf002

commit dfc36a12c97b9ba3b2be0e9f8358e10d6c6bf002
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-10-24 19:29:39 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-10-24 19:29:39 +0000

    kde-apps/okular: Add missing DEPEND for IUSE="chm"
    
    Bug: https://bugs.gentoo.org/750941
    Package-Manager: Portage-3.0.8, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-apps/okular/okular-20.08.49.9999.ebuild | 4 +++-
 kde-apps/okular/okular-9999.ebuild          | 3 +++
 2 files changed, 6 insertions(+), 1 deletion(-)
Comment 9 Larry the Git Cow gentoo-dev 2020-10-25 00:28:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9d9bc7a7c9c608226dbe89c37c16157681835c6f

commit 9d9bc7a7c9c608226dbe89c37c16157681835c6f
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-10-24 21:14:44 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-10-25 00:27:41 +0000

    kde-apps/okular: Add missing DEPEND for IUSE="chm"
    
    Closes: https://bugs.gentoo.org/750941
    Package-Manager: Portage-3.0.8, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-apps/okular/okular-20.04.3-r1.ebuild | 114 +++++++++++++++++++++++++++++++
 kde-apps/okular/okular-20.08.2-r1.ebuild | 112 ++++++++++++++++++++++++++++++
 2 files changed, 226 insertions(+)