Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 750452 - >=www-client/firefox-78.4.0 and >=www-client/firefox-82.0 have changed their source tarball name
Summary: >=www-client/firefox-78.4.0 and >=www-client/firefox-82.0 have changed their ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-20 17:41 UTC by tt_1
Modified: 2020-10-21 05:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tt_1 2020-10-20 17:41:51 UTC
the name for the firefox source tarball, as saved in distfiles dir, has changed.

before: firefox-81.0.2.source.tar.xz BLAKE2B SHA512 size ;-) ... 

now: firefox-82.0.sources.tar.xz BLAKE2B SHA512 size ;-) ... 

why is this relevant? some people have slow internet connection and prefer to load the tar archive seperately from a faster connection, and transfer it to the gentoo machine via usb stick. 

I know that it's also super easy to rename the archive locally to your new name scheme, but I just can't find the reason for why it was altered in the first place?  

here's super trivial patch to revert: 

diff --git a/firefox-82.0.ebuild b/firefox-82.0.ebuild
index 9cb7e06..bec28bc 100644
--- a/firefox-82.0.ebuild
+++ b/firefox-82.0.ebuild
@@ -51,7 +51,7 @@ PATCH_URIS=(
 	https://dev.gentoo.org/~{axs,polynomial-c,whissi}/mozilla/patchsets/${FIREFOX_PATCHSET}
 )
 
-SRC_URI="${MOZ_SRC_BASE_URI}/source/${MOZ_P}.source.tar.xz -> ${MOZ_P_DISTFILES}.sources.tar.xz
+SRC_URI="${MOZ_SRC_BASE_URI}/source/${MOZ_P}.source.tar.xz -> ${MOZ_P_DISTFILES}.source.tar.xz
 	${PATCH_URIS[@]}"
 
 DESCRIPTION="Firefox Web Browser"


thanks for considering, it makes my life a lot easier. 
also affected: >=spidermonkey-78.4.0, since it shares the tarball name with firefox-esr
Comment 1 Thomas Deutschmann (RETIRED) gentoo-dev 2020-10-20 20:46:56 UTC
That change was intentionally. It's required to be able to mirror beta/RC versions and don't clash later with final releases (notice that upstream always uses firefox-<version>.sources.tar.xz and version will never contain alpha/beta/rc information; instead upstream is controlling that via path which we cannot do when storing distfiles in single directory).
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2020-10-20 21:04:16 UTC
Wait, are you just talking about the "s"?
Comment 3 Larry the Git Cow gentoo-dev 2020-10-20 21:10:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=098fd3a0e6df7a21912261940a4e7e6d863b36fa

commit 098fd3a0e6df7a21912261940a4e7e6d863b36fa
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-10-20 21:07:13 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-10-20 21:07:13 +0000

    www-client/firefox: fix DISTFILE name
    
    Closes: https://bugs.gentoo.org/750452
    Package-Manager: Portage-3.0.8, Repoman-3.0.2
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox/Manifest              | 4 ++--
 www-client/firefox/firefox-78.4.0.ebuild | 2 +-
 www-client/firefox/firefox-82.0.ebuild   | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bd90500ea9de7d4f79059c94911be3777e523a9a

commit bd90500ea9de7d4f79059c94911be3777e523a9a
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-10-20 21:09:56 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-10-20 21:09:56 +0000

    mail-client/thunderbird: fix DISTFILE name
    
    Bug: https://bugs.gentoo.org/750452
    Package-Manager: Portage-3.0.8, Repoman-3.0.2
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 mail-client/thunderbird/Manifest                  | 2 +-
 mail-client/thunderbird/thunderbird-78.3.3.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7faafe83a54d629a11c5b7840047d7f90fb5bbab

commit 7faafe83a54d629a11c5b7840047d7f90fb5bbab
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-10-20 21:08:19 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-10-20 21:08:19 +0000

    dev-lang/spidermonkey: fix DISTFILE name
    
    Bug: https://bugs.gentoo.org/750452
    Package-Manager: Portage-3.0.8, Repoman-3.0.2
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 dev-lang/spidermonkey/Manifest                   | 2 +-
 dev-lang/spidermonkey/spidermonkey-78.4.0.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 4 Thomas Deutschmann (RETIRED) gentoo-dev 2020-10-20 21:13:33 UTC
I thought you were unhappy about the introduced MOZ_P_DISTFILES,

> @@ -28,6 +34,8 @@
> 
>  MOZ_PN="${PN%-bin}"
>  MOZ_P="${MOZ_PN}-${MOZ_PV}"
> +MOZ_PV_DISTFILES="${MOZ_PV}${MOZ_PV_SUFFIX}"
> +MOZ_P_DISTFILES="${MOZ_PN}-${MOZ_PV_DISTFILES}"
> 
>  inherit autotools check-reqs desktop flag-o-matic gnome2-utils llvm \
>         multiprocessing pax-utils python-any-r1 toolchain-funcs \
> @@ -43,13 +51,13 @@
>         https://dev.gentoo.org/~{axs,polynomial-c,whissi}/mozilla/patchsets/${FIREFOX_PATCHSET}
>  )
> 
> -SRC_URI="${MOZ_SRC_BASE_URI}/source/${MOZ_P}.source.tar.xz
> +SRC_URI="${MOZ_SRC_BASE_URI}/source/${MOZ_P}.source.tar.xz -> ${MOZ_P_DISTFILES}.source.tar.xz

which happened on purpose. But I guess you are probably not affected because you don't care about non-release ebuilds...

Happy now?
Comment 5 tt_1 2020-10-21 05:36:11 UTC
(In reply to Thomas Deutschmann from comment #2)
> Wait, are you just talking about the "s"?

yeah, that's all. now the tarball file name is the same as on upstream mirrors. thank you for fixing! :)