Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 750008 - kde-plasma/discover: Please add flatpak support
Summary: kde-plasma/discover: Please add flatpak support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-18 19:27 UTC by SpikyAtLinux
Modified: 2020-10-25 00:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild patch for version 5.19.5 (discover-5.19.5-r1.ebuild.patch,1.08 KB, patch)
2020-10-18 19:27 UTC, SpikyAtLinux
Details | Diff
Ebuild patch for version 5.20.0 (discover-5.20.0-r1.ebuild.patch,1.08 KB, patch)
2020-10-18 19:28 UTC, SpikyAtLinux
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description SpikyAtLinux 2020-10-18 19:27:56 UTC
Created attachment 666644 [details, diff]
Ebuild patch for version 5.19.5

I´ve edited ebuild in my local overlay and it seems to work on both stable and testing arch.
Comment 1 SpikyAtLinux 2020-10-18 19:28:27 UTC
Created attachment 666647 [details, diff]
Ebuild patch for version 5.20.0
Comment 2 Andreas Sturmlechner gentoo-dev 2020-10-18 21:05:32 UTC
Thanks for your contribution, but the patch needs some work.

- Please keep the use-conditional dependencies block sorted
- One line per dependency
- sys-apps/appstream needs a slot operator for rebuild on subslot change
- Your mycmakeargs changes are unconditional, even though you added a flatpak use flag - both need a use flag switch, see also how it is done with "firmware" and "telemetry"

We'll add this with >=5.20 exclusively, especially since sys-apps/flatpak isn't stable yet either.

Feel free to file a PR in kde overlay instead, so I can merge your contribution with full credits. From there it will enter the Gentoo repository with the upcoming Plasma version bump.
Comment 3 Larry the Git Cow gentoo-dev 2020-10-25 00:26:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=ecb7ec7c08576bca3dd345a7873aff86de8fe75b

commit ecb7ec7c08576bca3dd345a7873aff86de8fe75b
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-10-24 22:56:06 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-10-24 22:56:06 +0000

    kde-plasma/discover: Add IUSE=flatpak
    
    Closes: https://bugs.gentoo.org/750008
    Package-Manager: Portage-3.0.8, Repoman-3.0.2
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-plasma/discover/discover-5.20.49.9999.ebuild | 11 +++++++----
 kde-plasma/discover/discover-9999.ebuild         | 11 +++++++----
 kde-plasma/discover/metadata.xml                 |  1 +
 3 files changed, 15 insertions(+), 8 deletions(-)