Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 749615 - dune.eclass: Add --docdir, --mandir parameters
Summary: dune.eclass: Add --docdir, --mandir parameters
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mark Wright
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 748774
  Show dependency tree
 
Reported: 2020-10-17 03:16 UTC by Sam James
Modified: 2020-10-31 09:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-10-17 03:16:29 UTC
For ocaml-gettext, I needed to add an unpleasant hack in order to install to the correct man page directories (instead of /usr/man).

It looks like Dune supports --mandir and --docdir, so we should provide that.
Comment 1 Rafael Kitover 2020-10-17 11:57:52 UTC
I will get on this, thanks for letting me know.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-10-17 12:01:35 UTC
(In reply to Rafael Kitover from comment #1)
> I will get on this, thanks for letting me know.

No problem at all, thank you for the work!
Comment 3 Rafael Kitover 2020-10-17 14:57:05 UTC
Do you know what the situation is with the dune packages, I see this in eix:

U] dev-ml/dune
     Доступные версии:      2.1.0(0/2.1.0)^t{tbz2} (~)2.7.1(0/2.7.1)^t {test}
     Установленные версии:  2.1.0(0/2.1.0)^t{tbz2}(10:30:09 09.06.2020)(-test)
     Домашняя страница:     https://github.com/ocaml/dune
     Описание:              A composable build system for OCaml

* dev-ml/dune-configurator
     Доступные версии:      (~)2.7.1(0/2.7.1)^t {+ocamlopt test}
     Домашняя страница:     https://github.com/ocaml/dune
     Описание:              A composable build system for OCaml

* dev-ml/dune-private-libs
     Доступные версии:      (~)2.7.1(0/2.7.1)^t {+ocamlopt test}
     Домашняя страница:     https://github.com/ocaml/dune
     Описание:              A composable build system for OCaml

unless I'm mistaken, all three of these are packages of dune itself.

Is this intentional?
Comment 4 Rafael Kitover 2020-10-17 15:39:45 UTC
Oh I see, these are different libraries built from the dune source.
Comment 5 Rafael Kitover 2020-10-17 16:05:03 UTC
https://github.com/gentoo/gentoo/pull/17957
Comment 6 Rafael Kitover 2020-10-17 16:52:29 UTC
I cannot add --docdir until dune 2.1.0 is dropped, because it does not have it, but there is already a workaround for that in the eclass.
Comment 7 Larry the Git Cow gentoo-dev 2020-10-31 09:47:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=06e720f4132ed3b5b5ad39dc3deb7e7493fdadc3

commit 06e720f4132ed3b5b5ad39dc3deb7e7493fdadc3
Author:     Rafael Kitover <rkitover@gmail.com>
AuthorDate: 2020-10-17 15:52:10 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-10-31 09:47:40 +0000

    dune.eclass: pass --mandir to dune install
    
    Closes: https://bugs.gentoo.org/749615
    Signed-off-by: Rafael Kitover <rkitover@gmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 eclass/dune.eclass | 1 +
 1 file changed, 1 insertion(+)