Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 749609 - net-p2p/mldonkey: needs port to OCaml 4.10 (drop unsafe-string usage)
Summary: net-p2p/mldonkey: needs port to OCaml 4.10 (drop unsafe-string usage)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jesús P Rey (Chuso)
URL: https://github.com/ygrek/mldonkey/iss...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: ocaml-4.10
  Show dependency tree
 
Reported: 2020-10-17 02:30 UTC by Sam James
Modified: 2024-10-01 23:13 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-10-17 02:30:18 UTC 
See upstream bug.
Comment 1 Andreas Sturmlechner gentoo-dev 2022-01-15 11:05:03 UTC 
Maybe a look at recent master commits is worth it https://github.com/ygrek/mldonkey/commits/master
Comment 2 Jesús P Rey (Chuso) 2022-01-15 18:31:39 UTC 
Yes, I saw that commit that says "fix build with 4.12", but the commit message also says it still requires unsafe strings, so not really a fix for this issue.

That commit only added two lines, the fix for unsafe string will require many more changes.
Comment 3 Eli Schwartz gentoo-dev 2024-09-19 14:20:11 UTC 
Should be fixed in 3.2.0 / 3.2.1 now?
Comment 4 Larry the Git Cow gentoo-dev 2024-10-01 23:13:21 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6f1821977ea27d5d23a6e32f78ffbcf1776527ca

commit 6f1821977ea27d5d23a6e32f78ffbcf1776527ca
Author:     Jesus P Rey (Chuso) <gentoo@chuso.net>
AuthorDate: 2024-09-30 21:04:07 +0000
Commit:     Eli Schwartz <eschwartz@gentoo.org>
CommitDate: 2024-10-01 23:04:11 +0000

    net-p2p/mldonkey: 3.2.1 version bump.
    
    Removed inactive and obsolete Sourceforge upstream.
    
    Closes: https://bugs.gentoo.org/749609
    Closes: https://bugs.gentoo.org/921257
    Signed-off-by: Jesus P Rey (Chuso) <gentoo@chuso.net>
    Closes: https://github.com/gentoo/gentoo/pull/38838
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>

 net-p2p/mldonkey/Manifest              |   1 +
 net-p2p/mldonkey/metadata.xml          |   1 -
 net-p2p/mldonkey/mldonkey-3.2.1.ebuild | 128 +++++++++++++++++++++++++++++++++
 3 files changed, 129 insertions(+), 1 deletion(-)