Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 749588 - net-im/teams "wrong" installation directory
Summary: net-im/teams "wrong" installation directory
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Stephan Hartmann (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-16 17:42 UTC by Michelangelo Scopelliti
Modified: 2021-06-28 08:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
tentative ebuild (new version) (teams-1.3.00.30857.ebuild,1.74 KB, text/plain)
2020-12-06 14:10 UTC, Michelangelo Scopelliti
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michelangelo Scopelliti 2020-10-16 17:42:57 UTC
net-im/teams is a binary-only package, AFAICT based on chromium.

As a binary packages, shouldn't be installed in /opt? The path change is trivial in usr/bin/teams script.

Besides, the license(s) should include "APSL-2 Apache-2.0 Artistic-2 BSD BSD-1 BSD-2 Boost-1.0 CC-BY-SA-3.0 CC0-1.0 ISC LGPL-2.1 MIT MIT-with-advertising ZLIB icu ms-teams-pre openssl" as indicated in usr/share/teams/LICENSES.chromium.html

Reproducible: Always




emerge --info

Portage 3.0.8 (python 3.7.9-final-0, default/linux/amd64/17.1, gcc-10.2.0, glibc-2.32-r2, 5.9.0 x86_64)
=================================================================
System uname: Linux-5.9.0-x86_64-Intel-R-_Core-TM-_i7-7700_CPU_@_3.60GHz-with-gentoo-2.7
KiB Mem:    32592312 total,  12118572 free
KiB Swap:   33554428 total,  33554428 free
Head commit of repository gentoo: 8db0876c9d6bb37167eb561445fe08e694b423e3

sh bash 5.0_p18
ld GNU ld (Gentoo 2.35.1 p1) 2.35.1
app-shells/bash:          5.0_p18::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.30.3-r1::gentoo
dev-lang/python:          2.7.18-r4::gentoo, 3.7.9::gentoo, 3.8.6::gentoo, 3.9.0::gentoo
dev-util/cmake:           3.18.4::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.13.4-r2::gentoo, 1.16.2::gentoo
sys-devel/binutils:       2.35.1::gentoo
sys-devel/gcc:            10.2.0-r2::gentoo
sys-devel/gcc-config:     2.3.2::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.9::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32-r2::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo/gentoo.git
    priority: -1000

kernelpanic
    location: /var/db/repos/kernelpanic
    masters: gentoo
    priority: 0

kernelpanic-fixes
    location: /var/db/repos/kernelpanic-fixes
    masters: gentoo
    priority: 0

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE @BINARY-REDISTRIBUTABLE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=native -mtune=native -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -march=native -mtune=native -pipe"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -march=native -mtune=native -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg cgroup clean-logs compress-build-logs config-protect-if-modified distlocks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms split-elog split-log strict unknown-features-warn unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -march=native -mtune=native -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="it_IT.UTF-8"
LDFLAGS="-Wl,-O2 -Wl,--as-needed"
MAKEOPTS="-j9"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 amr ao berkdb blas bluray branding bzip2 cairo cdda clang cli crypt cups curl dbus djvu dri dvb dvd elogind encode eselect-ldso exif ffmpeg fftw flac fontconfig fortran fribidi gdbm gif gimp gmp gnome-keyring gsm gtk harfbuzz heif iconv icu imlib inotify ipv6 jbig jemalloc jit jpeg jpeg2k lapack lcms libass libglvnd libnotify libressl libsamplerate libtirpc llvm lto luajit lz4 lzma lzo mms mng mp3 mpeg multilib natspec ncurses nls nptl nss offensive ogg openal opencl opencv openexr opengl openmp opus pam pango pcre pcre16 pdf png policykit postproc postscript pulseaudio raw readline scanner seccomp smp sndfile sox speex spell split-usr ssl svg theora threads tiff truetype udev udisks unicode usb vaapi vdpau vim-syntax vorbis vpx vulkan wavpack webp wmf x264 xattr xcb xcomposite xdg xetex xml xpm xv xvid zip zlib zstd" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sse sse2 sse3 sse4_1 sse4_2 ssse3" CURL_SSL="libressl" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput wacom" KERNEL="linux" L10N="it en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="BPF" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2 php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_7" PYTHON_TARGETS="python2_7 python3_7" RUBY_TARGETS="ruby27" SANE_BACKENDS="hp" USERLAND="GNU" VIDEO_CARDS="intel i965 iris" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Andreas K. Hüttel archtester gentoo-dev 2020-10-24 15:58:23 UTC
Let's try this in a future version. I am wary to meddle too much with the installation in one go.
Comment 2 Joakim Tjernlund 2020-11-25 09:17:57 UTC
Maybe replace
 cat > 99teams <<-EOF
		LDPATH=${EROOT}/usr/$(get_libdir)/chromium
		EOF
		doenvd 99teams
with as symlink to not impose system libffmpeg.so on all apps
Comment 3 Michelangelo Scopelliti 2020-12-06 14:10:55 UTC
Created attachment 677023 [details]
tentative ebuild (new version)

This is a tentative ebuild for the new (1.3.00.30857) version (see bug #758257).

Besides the licensing issues, the dependencies were heavily changed (checked with ldd) and, apparently, gtk+:3[X] accounts for almost everything. A quick test with system mesa showed no issues (on my systems, at least); ffmpeg testing requires some more time.

It is my opinion that language packs could be removed, but doing it safely requires time. And, since the package is chromium-based, maybe some namespace checking may be needed.

This proposed ebuild tries also to account for comment #2 concerns.

In any case, this is the ebuild I'm using right now.
Comment 4 Joonas Niilola gentoo-dev 2020-12-07 06:04:00 UTC
(In reply to Michelangelo Scopelliti from comment #0)
> 
> As a binary packages, shouldn't be installed in /opt? The path change is
> trivial in usr/bin/teams script.
> 

It doesn't matter whether it's a binary or not, if it complies to unix FHS. Ie has proper /usr/{bin,lib,share} directory structure. /opt is used for packages that just dump everything in a single directory and calls the binary there. Like:
$ ls /opt/spotify/spotify-client/
Apps                 cef.pak                 libEGL.so          spotify.desktop
apt-keys             devtools_resources.pak  libGLESv2.so       swiftshader
cef_100_percent.pak  icons                   locales            v8_context_snapshot.bin
cef_200_percent.pak  icudtl.dat              snapshot_blob.bin
cef_extensions.pak   libcef.so               spotify

I haven't used Teams but I can believe it behaves similarily. Just wanted to clear that up.
Comment 5 Michelangelo Scopelliti 2020-12-07 10:07:45 UTC
(In reply to Joonas Niilola from comment #4)
[CUT]
> It doesn't matter whether it's a binary or not, if it complies to unix FHS.
> Ie has proper /usr/{bin,lib,share} directory structure. /opt is used for
> packages that just dump everything in a single directory and calls the
> binary there. Like:
> $ ls /opt/spotify/spotify-client/
[CUT]
> I haven't used Teams but I can believe it behaves similarily. Just wanted to
> clear that up.

Thank you for the clarification. When I was forced to use Teams at my workplace, I didn't find an ebuild and I wrote one based on the skypeforlinux ebuild. After all, it's just the same chromium stuff.
Comment 6 Larry the Git Cow gentoo-dev 2021-06-28 08:14:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8041ecd8735fa711583ddc611e21e425dd6215a2

commit 8041ecd8735fa711583ddc611e21e425dd6215a2
Author:     Stephan Hartmann <sultan@gentoo.org>
AuthorDate: 2021-06-28 08:12:58 +0000
Commit:     Stephan Hartmann <sultan@gentoo.org>
CommitDate: 2021-06-28 08:13:13 +0000

    net-im/teams: bump to 1.4.00.13653
    
    Also rework ebuild a bit and move to /opt.
    
    Closes: https://bugs.gentoo.org/796356
    Closes: https://bugs.gentoo.org/749588
    Package-Manager: Portage-3.0.20, Repoman-3.0.2
    Signed-off-by: Stephan Hartmann <sultan@gentoo.org>

 net-im/teams/Manifest                  |   1 +
 net-im/teams/metadata.xml              |   1 +
 net-im/teams/teams-1.4.00.13653.ebuild | 105 +++++++++++++++++++++++++++++++++
 3 files changed, 107 insertions(+)