Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 749378 - sys-libs/libseccomp-2.5.0: compile failure on mips architecture
Summary: sys-libs/libseccomp-2.5.0: compile failure on mips architecture
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: MIPS Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: https://github.com/seccomp/libseccomp...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-16 03:37 UTC by Joshua Kinard
Modified: 2021-02-08 19:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Kinard gentoo-dev 2020-10-16 03:37:02 UTC 
libseccomp-2.5.0 has a compile failure on mips due to an upstream change that conflicts with a compiler-defined macro:

libtool: compile:  mips64-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/usr/obj/portage/sys-libs/libseccomp-2.5.0/work/libseccomp-2.5.0/src -I.. -I/usr/obj/portage/sys-libs/libseccomp-2.5.0/work/libseccomp-2.5.0/include -I../include -Wall -O2 -pipe -march=r12k -mtune=r12k -mno-fix-r10000 -mabi=n32 -mplt -fomit-frame-pointer -fno-stack-protector -fPIC -DPIC -fvisibility=hidden -O2 -pipe -march=r12k -mtune=r12k -mno-fix-r10000 -mabi=n32 -mplt -fomit-frame-pointer -fno-stack-protector -c /usr/obj/portage/sys-libs/libseccomp-2.5.0/work/libseccomp-2.5.0/src/arch-x86.c  -fPIC -DPIC -o .libs/libseccomp_la-arch-x86.o
/usr/obj/portage/sys-libs/libseccomp-2.5.0/work/libseccomp-2.5.0/src/syscalls.h:44:6: error: expected identifier or '(' before numeric constant
   44 |  int mips;
      |      ^~~~
make[3]: *** [Makefile:865: libseccomp_la-arch-x86.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:1356: all-recursive] Error 1
make[1]: *** [Makefile:514: all-recursive] Error 1
make: *** [Makefile:423: all] Error 2
 * ERROR: sys-libs/libseccomp-2.5.0::gentoo failed (compile phase):
 *   emake failed

Upstream has since fixed this by setting -Umips in configure.ac in AM_FLAGS, and then modifying Makefile.in to include it.  I looked at the ebuild, and it currently does not call eautoreconf, and I am hesitant to add it for this one version.  Upstream should have the fix included when libseccomp-2.5.1 is released, so I am going to mask 2.5.0 for the time being, and this bug will serve as a reminder to recheck things in 2.5.1.  libseccomp-2.4.4 currently compiles on mips, so that version will keep us covered.
Comment 1 Larry the Git Cow gentoo-dev 2020-10-16 03:45:58 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4b140c170702c113f07a587b21724ba3be44c6ba

commit 4b140c170702c113f07a587b21724ba3be44c6ba
Author:     Joshua Kinard <kumba@gentoo.org>
AuthorDate: 2020-10-16 03:45:20 +0000
Commit:     Joshua Kinard <kumba@gentoo.org>
CommitDate: 2020-10-16 03:45:20 +0000

    sys-libs/libseccomp: Negate the MIPS keyword on 2.5.0
    
    There is a compile failure on the MIPS architecture for libseccomp-2.5.0
    that is fixed in upstream and will be in libseccomp-2.5.1.  We can hold
    at v2.4.4 for now until the next version comes out.
    
    Bug: https://bugs.gentoo.org/749378
    Signed-off-by: Joshua Kinard <kumba@gentoo.org>
    Package-Manager: Portage-3.0.8, Repoman-3.0.1

 sys-libs/libseccomp/libseccomp-2.5.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 Joshua Kinard gentoo-dev 2021-02-08 19:48:47 UTC 
Recently built libseccomp-2.5.1 on mips64 and it compiles without issue.  Marking this as RESOLVED UPSTREAM, since the fix happened there.