Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 749360 - media-sound/volumeicon-0.5.1-r1: libnotify option doesn't work
Summary: media-sound/volumeicon-0.5.1-r1: libnotify option doesn't work
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-16 00:20 UTC by Nikita Zlobin
Modified: 2021-02-12 23:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Zlobin 2020-10-16 00:20:47 UTC 
configure.ac has mistake, when NOTIFY_CFLAGS is set with += operator, which doesn't work in shell. Still not fixed, nor even reported. As result, this option is not passed during build.
This should fix it:
$ sed -e 's/NOTIFY_CFLAGS+="/CFLAGS="${NOTIFY_CFLAGS} /' configure.ac

Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2021-02-12 23:39:50 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=33a9d9214df534a3aa9b32665e55e4c0c39c8b30

commit 33a9d9214df534a3aa9b32665e55e4c0c39c8b30
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2021-02-12 23:34:08 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2021-02-12 23:34:08 +0000

    media-sound/volumeicon: fix libnotify
    
    Closes: https://bugs.gentoo.org/749360
    Closes: https://github.com/gentoo/gentoo/pull/10945
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 .../files/volumeicon-0.5.1-fix-libnotify.patch     | 22 ++++++++++++
 media-sound/volumeicon/volumeicon-0.5.1-r2.ebuild  | 41 ++++++++++++++++++++++
 2 files changed, 63 insertions(+)