Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 747868 - sys-auth/pambase-20201010 - duplicate auth rules (pam_faillock.so and pam_unix.so)
Summary: sys-auth/pambase-20201010 - duplicate auth rules (pam_faillock.so and pam_uni...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-11 18:24 UTC by Shiba
Modified: 2020-10-13 18:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Shiba 2020-10-11 18:24:17 UTC
After upgrading to sys-auth/pambase-20201010 I have this new block in both system-login and system-auth:

auth            required        pam_faillock.so preauth conf=/etc/security/faillock.conf
auth            sufficient      pam_unix.so nullok try_first_pass
auth            [default=die]   pam_faillock.so authfail

However system-login includes system-auth, so it seems a bit redundant to have it in system-login too.

The other thing I noticed is that now in system-auth there are 2 rules for pam_unix.so:

auth		required	pam_unix.so try_first_pass likeauth nullok
[...cropped...]
auth            required        pam_faillock.so preauth conf=/etc/security/faillock.conf
auth            sufficient      pam_unix.so nullok try_first_pass
auth            [default=die]   pam_faillock.so authfail

I don't think this is the intended behavior, but I might be overlooking something.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-10-11 18:26:57 UTC
Thank you, this needs moving.
Comment 2 Larry the Git Cow gentoo-dev 2020-10-12 15:28:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/pambase.git/commit/?id=da499cca70c5e77c851c5f75440df188fe2eeabe

commit da499cca70c5e77c851c5f75440df188fe2eeabe
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2020-10-11 20:55:39 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-10-12 14:32:12 +0000

    templates/system-login.tpl: remove duplicate block from system-auth
    
    Bug: https://bugs.gentoo.org/747868
    Signed-off-by: Sam James <sam@gentoo.org>

 templates/system-login.tpl | 5 -----
 1 file changed, 5 deletions(-)
Comment 3 Shiba 2020-10-12 20:55:39 UTC
Thank you! Also could you please take a look at https://bugs.gentoo.org/747793#c4? The call to "pam_faillock.so authsucc" is missing, so the consecutive failed authentication counter is never reset.