Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 747592 - dev-libs/zookeeper-c-3.4.10 fails to compile
Summary: dev-libs/zookeeper-c-3.4.10 fails to compile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Alexis Ballier
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-10-10 13:39 UTC by Agostino Sarubbo
Modified: 2021-04-26 17:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,24.25 KB, text/plain)
2020-10-10 13:39 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-10-10 13:39:35 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/zookeeper-c-3.4.10 fails to compile.
Discovered on: amd64 (internal ref: tinderbox)

NOTE:
This machine uses a gold linker (ld.gold).
If you think that this issue is strictly related to ld.gold please block bug 269315.
Comment 1 Agostino Sarubbo gentoo-dev 2020-10-10 13:39:38 UTC
Created attachment 664534 [details]
build.log

build log and emerge --info
Comment 2 Joonas Niilola gentoo-dev 2021-01-08 07:20:35 UTC
I have the same error without gold linker. Looks to be -Wall -Werror related.
Comment 3 kfm 2021-02-15 23:27:16 UTC
The issue can be addressed by applying patches #14 and #17 from the following patchset.

https://salsa.debian.org/java-team/zookeeper/-/tree/e9d4b698f6c6dd12cf2e17292c56d60c71897638/debian/patches
Comment 4 kfm 2021-02-15 23:46:35 UTC
I should add that these two patches are still needed for version 3.4.14. I don't know about later versions. Below is a working ebuild.

https://bitbucket.org/kerframil/portage-overlay/src/d94ac40/dev-libs/zookeeper-c/
Comment 5 Agostino Sarubbo gentoo-dev 2021-02-16 07:32:01 UTC
Hello, thanks for the patch. I believe you can speed up the process by making a pull-request via Github.
Comment 6 kfm 2021-02-16 08:28:40 UTC
(In reply to Agostino Sarubbo from comment #5)
> Hello, thanks for the patch. I believe you can speed up the process by
> making a pull-request via Github.

I appreciate the suggestion, Agostino. However, I shall not use GitHub. There are several reasons but this is actually one of them: that independent infrastructure is gradually eroded by the expectation of having to be in a big-tech sanctioned club and contingent upon their ethically dubious terms, conditions and practices. If this is to be the future, then I would seriously consider finding other pursuits.

That said, I can supply a patch that may be directly applied against the repo. Before doing so, I shall test the USE flag combinations thoroughly.
Comment 7 Larry the Git Cow gentoo-dev 2021-03-16 13:18:02 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8e2ea28012b31589b4624d8e324ce2f3de55106a

commit 8e2ea28012b31589b4624d8e324ce2f3de55106a
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2021-03-16 13:16:33 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-03-16 13:17:54 +0000

    package.mask: last-rite dev-libs/zookeeper-c
    
    Bug: https://bugs.gentoo.org/664776
    Bug: https://bugs.gentoo.org/747592
    
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 8 kfm 2021-03-16 13:55:11 UTC
A somewhat disappointing decision as it renders Gentoo an even less attractive platform on which to deploy certain Apache products and to develop programs that interact with them. Consequently, I shall maintain the ebuild in my own repo for as long as I am able to.
Comment 9 Joonas Niilola gentoo-dev 2021-03-17 07:03:47 UTC
(In reply to Kerin Millar from comment #8)
> A somewhat disappointing decision as it renders Gentoo an even less
> attractive platform on which to deploy certain Apache products and to
> develop programs that interact with them. Consequently, I shall maintain the
> ebuild in my own repo for as long as I am able to.

Surely having a broken, unfixed, unmaintained package doesn't contribute to that attractiveness either.

If you'd like to keep this package, then please provide a git am'able patch file in here or via e-mail with your proper sign-off included.
  https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin

Also do consider becoming a maintainer via proxy-maint project, 
  https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/User_Guide#Proxied_maintainer_in_metadata.xml
as it seems basically unmaintained at this point.
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-03-17 07:30:02 UTC
(In reply to Kerin Millar from comment #8)
> A somewhat disappointing decision as it renders Gentoo an even less
> attractive platform on which to deploy certain Apache products and to
> develop programs that interact with them. Consequently, I shall maintain the
> ebuild in my own repo for as long as I am able to.

I think you know I'd be willing to proxy in whatever form fits us both! I agree it's a shame, but it's not like it's being looked after right now.

Anyway, speak to me if you do want to take it up.
Comment 11 kfm 2021-03-17 09:33:15 UTC
(In reply to Joonas Niilola from comment #9)
> (In reply to Kerin Millar from comment #8)
> > A somewhat disappointing decision as it renders Gentoo an even less
> > attractive platform on which to deploy certain Apache products and to
> > develop programs that interact with them. Consequently, I shall maintain the
> > ebuild in my own repo for as long as I am able to.
> 
> Surely having a broken, unfixed, unmaintained package doesn't contribute to
> that attractiveness either.
> 
> If you'd like to keep this package, then please provide a git am'able patch
> file in here or via e-mail with your proper sign-off included.
>   https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin

Thanks. I had intended to do just that but simply forgot.

> 
> Also do consider becoming a maintainer via proxy-maint project, 
>  
> https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/
> User_Guide#Proxied_maintainer_in_metadata.xml
> as it seems basically unmaintained at this point.

Alright. I'll take a look. Thank you also to Sam for commenting.
Comment 12 Larry the Git Cow gentoo-dev 2021-04-14 16:12:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b347510c63c07a6c84f294efb288a879801edee

commit 3b347510c63c07a6c84f294efb288a879801edee
Author:     Jakov Smolic <jakov.smolic@sartura.hr>
AuthorDate: 2021-04-14 00:11:16 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-04-14 16:10:48 +0000

    dev-libs/zookeeper-c: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/664776
    Closes: https://bugs.gentoo.org/747592
    Closes: https://bugs.gentoo.org/623328
    Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
    Closes: https://github.com/gentoo/gentoo/pull/20372
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/zookeeper-c/Manifest                  |  3 --
 dev-libs/zookeeper-c/metadata.xml              |  8 -----
 dev-libs/zookeeper-c/zookeeper-c-3.4.10.ebuild | 46 --------------------------
 dev-libs/zookeeper-c/zookeeper-c-3.4.8.ebuild  | 37 ---------------------
 dev-libs/zookeeper-c/zookeeper-c-3.4.9.ebuild  | 37 ---------------------
 profiles/package.mask                          | 26 ++++++++++++---
 6 files changed, 22 insertions(+), 135 deletions(-)
Comment 13 stathis 2021-04-26 17:46:27 UTC
For those who may still need zookeeper-c (for example to build pecl-rdkafka against!), I "maintain" v3.5.x version for my own personal use in my overlay here:

 https://github.com/sigmoidal/gentoo-overlay

it is really a hack, but it worked for me. maybe it works for someone else out there too.