Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 747487 - media-gfx/gimp-2.10.22 should depend on media-gfx/mypaint-brushes:2.0
Summary: media-gfx/gimp-2.10.22 should depend on media-gfx/mypaint-brushes:2.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sergey Torokhov
URL:
Whiteboard:
Keywords: PullRequest
: 750488 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-10-09 23:59 UTC by Maciej S. Szmigiero
Modified: 2020-10-21 05:59 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej S. Szmigiero 2020-10-09 23:59:35 UTC
media-gfx/gimp-2.10.22 depends on '>=media-gfx/mypaint-brushes-1.3.0:='.

media-gfx/mypaint-brushes-1.3.0-r1 matches this spec, however GIMP does not build with it:
> checking for mypaint-brushes-2.0... no
> configure: Eeeeeeeeeeeeeeeeeeeeek! Missing dep: mypaint-brushes-2.0
> Package mypaint-brushes-2.0 was not found in the pkg-config search path.
> Perhaps you should add the directory containing `mypaint-brushes-2.0.pc'
> to the PKG_CONFIG_PATH environment variable
> No package 'mypaint-brushes-2.0' found

If I install media-gfx/mypaint-brushes:2.0 manually GIMP builds successfully.
Comment 1 Sergey Torokhov 2020-10-10 01:42:28 UTC
Yes, I certainly missed it on version bump and forgot to update dependency while removing mypaint-brushes version check within gimp ebuild.

I wouldn't like to revision bump this time to fix it
as media-gfx/mypaint-brushes-1.3.0 was absent in portage tree
at the time of media-gfx/gimp-2.10.22 was added.
The mypaint-brushes-1.3.0-r1 removed on 25 Sep 2020 while gimp-2.10.22 was added 08 Oct 2020.
So there is no issue for updated system.

Thank you for report. I leave this issue open as a reminder for next revision.

P.S.
If you are required AVIF support that was added to gimp-2.10.22 then
please wait for media-libs/libheif-1.9.x version bump there avif support will be switch on.
Comment 2 Maciej S. Szmigiero 2020-10-10 15:33:53 UTC
Thanks for your work Sergey!
Comment 3 Sergey Torokhov 2020-10-10 15:57:20 UTC
Although, currently the installation of libaom and then re-emerge of >=libheif-1.7.0 should add avif support to libheif. There is an automatic dependency search within libheif  configure.ac if libaom is presence in system or not.
Comment 4 Sergey Torokhov 2020-10-21 05:20:11 UTC
*** Bug 750488 has been marked as a duplicate of this bug. ***
Comment 5 Larry the Git Cow gentoo-dev 2020-10-21 05:59:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=573e3d41bfb1ff44af4fa54d2912f0b49779ddd1

commit 573e3d41bfb1ff44af4fa54d2912f0b49779ddd1
Author:     band-a-prend <torokhov-s-a@yandex.ru>
AuthorDate: 2020-10-21 05:33:01 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-10-21 05:59:45 +0000

    media-gfx/gimp: 2.10.22 fix mypaint-brushes dependency
    
    While removing conditional check of mypaint-brushes version
    the appropreate version of this dependency wasn't updated
    resulting in configuration error if user still has mypaint-brushes-1.3.0,
    that was already removed from portage tree at gimp version bump.
    
    Offered change doesn't affect users that installed gimp-2.10.22
    so there is no revision bump.
    
    Closes: https://bugs.gentoo.org/747487
    Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru>
    Closes: https://github.com/gentoo/gentoo/pull/17985
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-gfx/gimp/gimp-2.10.22.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)