Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 747376 - sys-fs/cryfs-0.10.2: -DCMAKE_BUILD_TYPE=Gentoo builds a debug build
Summary: sys-fs/cryfs-0.10.2: -DCMAKE_BUILD_TYPE=Gentoo builds a debug build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-10-09 06:26 UTC by Tamas Jantvik
Modified: 2020-11-05 12:32 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Jantvik 2020-10-09 06:26:29 UTC
CryFS build system uses '-DCMAKE_BUILD_TYPE' to determine whether to build a debug build. If not set to 'Release', the build is a debug build, resulting in the message "WARNING! This is a debug build. Performance might be slow." being shown.

Reproducible: Always
Comment 1 Nick 2020-11-01 00:44:03 UTC
If I add -DNDEBUG in the ebuild using append-flags, it gets rid of the warning for me. I'm not 100% sure this is the most correct and future-proof way to disable the development build, but I see something similar done in dev-util/intel-graphics-compiler: https://github.com/gentoo/gentoo/blob/a50597d0202a4968147c1b5d96ebeeb1872b0ffe/dev-util/intel-graphics-compiler/intel-graphics-compiler-1.0.4111.ebuild#L50-L52

> # Since late March 2020 cmake.eclass does not set -DNDEBUG any more, and the way
> # IGC uses this definition causes problems for some users (see Bug #718824).
> use debug || append-cppflags -DNDEBUG

From the discussion in an upstream issue (https://github.com/cryfs/cryfs/issues/147) I'm not sure whether there is much of a known performance impact, but I can confirm that the warning goes away and that the following command:

  file `which cryfs`

gives "stripped" which I assume means it does not contain debugging symbols.
Comment 2 Larry the Git Cow gentoo-dev 2020-11-05 12:32:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e1b4322ae72c88dbd03fb66cd1c60a7e04a07a93

commit e1b4322ae72c88dbd03fb66cd1c60a7e04a07a93
Author:     Nicholas Meyer <nickaristocrates@gmail.com>
AuthorDate: 2020-10-31 22:34:34 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-11-05 12:32:03 +0000

    sys-fs/cryfs: remove debug warning on sys-fs/cryfs[-debug]
    
    Closes: https://bugs.gentoo.org/747376
    Signed-off-by: Nicholas Meyer <nickaristocrates@gmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 sys-fs/cryfs/cryfs-0.10.2.ebuild | 1 +
 1 file changed, 1 insertion(+)