Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 746782 - ~dev-lua/luaexpat-1.3.3 fails net-im/prosody tests
Summary: ~dev-lua/luaexpat-1.3.3 fails net-im/prosody tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Azamat H. Hackimov
URL: https://issues.prosody.im/1375
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-10-05 21:55 UTC by Azamat H. Hackimov
Modified: 2021-02-20 18:56 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Azamat H. Hackimov 2020-10-05 21:55:41 UTC
As Conrad Kostecki @conikost pointed out, current dev-lua/luaexpat-1.3.3 is failing unittests of net-im/prosody:

>>> Test phase: net-im/prosody-0.11.7
make -j13 -l12   test
busted --lua=lua
●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●✱
307 successes / 0 failures / 1 error / 0 pending : 0.344227 seconds

Error → ./util/xmppstream.lua @ 21
suite spec/util_xmppstream_spec.lua
./util/xmppstream.lua:21: attempt to index local 'lxp' (a boolean value)
make: *** [Makefile:72: test] error 1

Seems dev-lua/luaexpat-1.3.3 is forked from original pre dev-lua/luaexpat-1.3.0 and lacks some major features that required by prosody. Seems dev-lua/luaexpat-1.3.3 is broken fork.

Needs clear out how to remediate that situation.
Comment 1 Larry the Git Cow gentoo-dev 2020-10-08 19:14:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ab1e3f3c9d6376fe6721ef6d45907ecee6cdae9a

commit ab1e3f3c9d6376fe6721ef6d45907ecee6cdae9a
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2020-10-05 22:13:25 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2020-10-08 19:13:42 +0000

    Masking >=dev-lua/luaexpat-1.3.3
    
    1.3.3 is broken and failing unittests for net-im/prosody.
    
    Closes: https://github.com/gentoo/gentoo/pull/17813
    Closes: https://bugs.gentoo.org/746782
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 profiles/package.mask | 4 ++++
 1 file changed, 4 insertions(+)
Comment 2 Azamat H. Hackimov 2020-10-08 20:12:29 UTC
Still not resolved.
Comment 3 Conrad Kostecki gentoo-dev 2021-02-17 20:24:02 UTC
Are there any ideas to fix that? Upstream doesn't seems really to care. Prosody also said, that they don't have an idea and are not really motivated to fix that.
Comment 4 Azamat H. Hackimov 2021-02-20 09:16:31 UTC
I decided to remove 1.3.3 version as it not true "fork" with new features, and stick with original 1.3.0.
Comment 5 Larry the Git Cow gentoo-dev 2021-02-20 18:56:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ac8c7819ed25d6ad0174456fa88113be32e10f24

commit ac8c7819ed25d6ad0174456fa88113be32e10f24
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2021-02-20 09:27:01 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2021-02-20 18:56:12 +0000

    dev-lua/luaexpat: Remove masked 1.3.3 version
    
    1.3.3 is "forked" version that cause regressions on dependencies (#746782).
    Since there no activity on forked project, package switched back to
    original version.
    
    Closes: https://bugs.gentoo.org/746782
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 dev-lua/luaexpat/Manifest                          |   1 -
 .../files/luaexpat-1.3.3_getcurrentbytecount.patch |  33 -------
 .../luaexpat/files/luaexpat-1.3.3_makefile.patch   |  21 ----
 .../luaexpat-1.3.3_restore_functionality.patch     | 109 ---------------------
 dev-lua/luaexpat/luaexpat-1.3.0-r102.ebuild        |   2 +-
 dev-lua/luaexpat/luaexpat-1.3.3-r102.ebuild        |  78 ---------------
 dev-lua/luaexpat/metadata.xml                      |   3 -
 7 files changed, 1 insertion(+), 246 deletions(-)