Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 746368 - media-video/makemkv-1.15.3: configure: test -z $CXXFLAGS is missing quotes
Summary: media-video/makemkv-1.15.3: configure: test -z $CXXFLAGS is missing quotes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal trivial (vote)
Assignee: James Le Cuirot
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-10-03 21:01 UTC by Matt Whitlock
Modified: 2020-10-12 21:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
1.15.3-configure-CXXFLAGS-quoting.patch (1.15.3-configure-CXXFLAGS-quoting.patch,356 bytes, patch)
2020-10-03 21:01 UTC, Matt Whitlock
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Whitlock 2020-10-03 21:01:40 UTC
Created attachment 663694 [details, diff]
1.15.3-configure-CXXFLAGS-quoting.patch

The configure script for media-video/makemkv-1.15.3 contains the line:

   if test -z $CXXFLAGS; then

This fails when $CXXFLAGS contains more than one word, emitting for example an error like:

   ./configure: 11729: test: -pipe: unexpected operator

The attached patch corrects the configure script.
Comment 1 Larry the Git Cow gentoo-dev 2020-10-12 21:08:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=43a573c4850f15bd97b15db5b481eebf9c4d9f28

commit 43a573c4850f15bd97b15db5b481eebf9c4d9f28
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2020-10-12 21:08:24 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2020-10-12 21:08:24 +0000

    media-video/makemkv: Patch around missing quotes in configure
    
    I have reported this upstream and I believe they will use a proper
    autoconf macro to set the -std flag in future.
    
    Closes: https://bugs.gentoo.org/746368
    Suggested-By: Matt Whitlock
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 .../makemkv/files/1.15.3-configure-CXXFLAGS-quoting.patch    | 12 ++++++++++++
 media-video/makemkv/makemkv-1.15.3.ebuild                    |  6 +++++-
 2 files changed, 17 insertions(+), 1 deletion(-)