Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 745936 - >=mail-client/thunderbird-78.3.1 should depend on net-libs/libotr
Summary: >=mail-client/thunderbird-78.3.1 should depend on net-libs/libotr
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-01 08:09 UTC by tt_1
Modified: 2023-09-17 06:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
output from emerge --info (emerge-info,7.68 KB, text/plain)
2020-10-01 08:09 UTC, tt_1
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tt_1 2020-10-01 08:09:03 UTC
from console output: 

thunderbird 
[calBackendLoader] Using Thunderbird's libical backend
console.debug: "Successfully loaded OpenPGP library librnp.so from /usr/lib64/thunderbird/librnp.so"
console.debug: "public keys: 0, secret keys: 0"
console.debug: "0 protected and 0 unprotected keys"
console.log: (new Error("Cannot load required OTR library", "resource:///modules/OTRLib.jsm", 75))


libotr.so.5 is provided by net-libs/libotr: 

thunderbird 
[calBackendLoader] Using Thunderbird's libical backend
console.debug: "Successfully loaded OpenPGP library librnp.so from /usr/lib64/thunderbird/librnp.so"
console.debug: "public keys: 0, secret keys: 0"
console.debug: "0 protected and 0 unprotected keys"
console.debug: "Successfully loaded OTR library libotr.so.5 from system's standard library locations"

it should suffice to put net-libs/libotr into runtime deps
Comment 1 tt_1 2020-10-01 08:09:19 UTC
Created attachment 663412 [details]
output from emerge --info
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2020-10-01 11:49:17 UTC
I saw that too but I disagree.

net-libs/libotr is optional and not required to build or run the program. It's only needed when you will use chat feature and also use a service which can make use of it (should be XMPP only).

I must think about adding USE=chat or maybe USE=otr but at the moment even that feels wrong to me.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-10-01 11:52:34 UTC
(In reply to Thomas Deutschmann from comment #2)
> I saw that too but I disagree.
> 
> net-libs/libotr is optional and not required to build or run the program.
> It's only needed when you will use chat feature and also use a service which
> can make use of it (should be XMPP only).
> 
> I must think about adding USE=chat or maybe USE=otr but at the moment even
> that feels wrong to me.

optfeature?
Comment 4 Georgy Yakovlev archtester gentoo-dev 2020-10-02 06:37:50 UTC
^ 2x

use conditional rdepend in a package with such a long build time is not ok for otr, which installs in seconds.

optfeature.eclass has been split out of eutils, so I'd use it.


I think it's better in the long run to introduce ${PN}-common, which acts sorta like a virtual, and installs optional files and/or pulls deps and is almost instant to rebuild, like llvm/clang do already.

for example it could try to handle js prefs mangling.
re-installing ff/tb for a hwaccell is overkill currently. it's literally 2 line change in a config file.
Awesome if it can load js files from dir.d style location.
I haven's looked what makes it load our prefs file.
But if it can load file if it exists and skip if it not - it'll be really great for user experience with those packages.

Also some runtime/buildtime deps can be moved to those -common packages, and, like it often happens, if a dependency was overlooked during major bump, instead of modifying ff/tb in place it may be better to do it in a -common package, especially for --changed-deps users.

languages probably can also moved into common package as well, looks like it just installs xpi files for each L10N flag.

just my 2 cents.
Comment 5 Larry the Git Cow gentoo-dev 2022-02-07 16:49:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6b50be5200ac4f43c0e441d1a38b941e01b4ca63

commit 6b50be5200ac4f43c0e441d1a38b941e01b4ca63
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-02-07 16:49:03 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-02-07 16:49:53 +0000

    mail-client/thunderbird-bin: optfeature for libotr
    
    Closes: https://bugs.gentoo.org/745936
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 mail-client/thunderbird-bin/thunderbird-bin-91.5.1.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=310dc243074cf9a83ebe2f4c27a42a6080dbc1c1

commit 310dc243074cf9a83ebe2f4c27a42a6080dbc1c1
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-02-07 16:47:39 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-02-07 16:49:53 +0000

    mail-client/thunderbird: optfeature for net-libs/libotr
    
    Closes: https://bugs.gentoo.org/745936
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 mail-client/thunderbird/thunderbird-91.5.1.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)