Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 745930 - >=www-client/firefox-78.3.1 and >=mail-client/thunderbird-78.3.1: QA Notice: temp/environment: line 4534: mozconfig_annotate: command not found
Summary: >=www-client/firefox-78.3.1 and >=mail-client/thunderbird-78.3.1: QA Notice: ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-01 07:53 UTC by tt_1
Modified: 2020-10-01 17:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
output from emerge --info (emerge-info,7.68 KB, text/plain)
2020-10-01 07:54 UTC, tt_1
Details
Firefox DRM warning (drm_warning.png,13.46 KB, image/png)
2020-10-01 17:27 UTC, Thomas Deutschmann (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tt_1 2020-10-01 07:53:18 UTC
I just emerged =mail-client/thunderbird-78.3.1 and got this message during merge:

>>> Completed installing mail-client/thunderbird-78.3.1 into /var/tmp/portage/mail-client/thunderbird-78.3.1/image

 * Final size of build directory: 5445156 KiB (  5.1 GiB)
 * Final size of installed tree:   218240 KiB (213.1 MiB)

 * QA Notice: command not found:
 * 
 * 	/var/tmp/portage/mail-client/thunderbird-78.3.1/temp/environment: line 4534: mozconfig_annotate: command not found
strip: x86_64-pc-linux-gnu-strip --strip-unneeded -N __gentoo_check_ldflags__ -R .comment -R .GCC.command.line -R .note.gnu.gold-version
   /usr/lib64/thunderbird/libprldap60.so
   /usr/lib64/thunderbird/libmozsandbox.so
   /usr/lib64/thunderbird/libldif60.so
   /usr/lib64/thunderbird/liblgpllibs.so
   /usr/lib64/thunderbird/libldap60.so
   /usr/lib64/thunderbird/pingsender
   /usr/lib64/thunderbird/librnp.so
   /usr/lib64/thunderbird/libmozsqlite3.so
   /usr/lib64/thunderbird/libmozgtk.so
   /usr/lib64/thunderbird/thunderbird
   /usr/lib64/thunderbird/plugin-container
   /usr/lib64/thunderbird/libxul.so
   /usr/lib64/thunderbird/gtk2/libmozgtk.so

source of mozconfig_annotate is here: 

https://github.com/gentoo/gentoo/blob/master/mail-client/thunderbird/thunderbird-78.3.1.ebuild#L649

https://github.com/gentoo/gentoo/blob/master/www-client/firefox/firefox-78.3.1.ebuild#L654
Comment 1 tt_1 2020-10-01 07:54:44 UTC
Created attachment 663409 [details]
output from emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2020-10-01 11:43:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7c4062d8beed70792727317685707f42942415c9

commit 7c4062d8beed70792727317685707f42942415c9
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-10-01 11:39:59 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-10-01 11:43:12 +0000

    mail-client/thunderbird: fix USE=eme-free
    
    Closes: https://bugs.gentoo.org/745930
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 mail-client/thunderbird/thunderbird-78.3.1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7cf984de44717f414cb1977e0e00b5a2372b121e

commit 7cf984de44717f414cb1977e0e00b5a2372b121e
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-10-01 11:39:01 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-10-01 11:43:12 +0000

    www-client/firefox: fix USE=eme-free
    
    Closes: https://bugs.gentoo.org/745930
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox/firefox-78.3.1.ebuild | 2 +-
 www-client/firefox/firefox-81.0.1.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 3 tt_1 2020-10-01 11:46:51 UTC
thanks for the fast fix

I have USE=+eme-free , do I have to rebuild now?
Comment 4 Ionen Wolkens gentoo-dev 2020-10-01 13:05:16 UTC
(In reply to tt_1 from comment #3)
> I have USE=+eme-free , do I have to rebuild now?
If want it to be effective then yes. Getting so many changes right now that I'd think better avoid revbumps for a bit.
Comment 5 Thomas Deutschmann (RETIRED) gentoo-dev 2020-10-01 17:27:48 UTC
Created attachment 663469 [details]
Firefox DRM warning

Actually I believe that USE=eme-free is obsolete:

The only available encrypted media extension is widevine at the moment (see https://github.com/Whissi/gentoo-mozilla/blob/firefox-esr-78.3.1/toolkit/moz.configure#L542-L594).

So we will end up with MOZ_EME_MODULES being defined.

This value is used in in https://github.com/Whissi/gentoo-mozilla/blob/firefox-esr-78.3.1/browser/moz.build#L47-L48

So we will end up with MOZ_WIDEVINE_EME being defined by default.

This value is used in https://github.com/Whissi/gentoo-mozilla/blob/firefox-esr-78.3.1/browser/app/profile/firefox.js#L182-L186

But this will only trigger attached DRM warning notification in Firefox.

> I have USE=+eme-free , do I have to rebuild now?

So no, you don't need to rebuild. If you don't want to see this notification when you hit DRM content, manually set "browser.eme.ui.enabled" to "false".

And why do I believe this option is obsolete? Because it's just a notification and it is good to tell user "This page shouldn't be empty/white but I need DRM to show something".

Widevine itself is delivered via Gecko Media Plugin (gmp-widevinecdm), i.e. firefox will try to download the required lib by default on first usage (after you will give permission) and store it in user's profile (for amd64 it's currently https://redirector.gvt1.com/edgedl/widevine-cdm/4.10.1582.2-linux-x64.zip as set in https://github.com/Whissi/gentoo-mozilla/blob/firefox-esr-78.3.1/toolkit/content/gmp-sources/widevinecdm.json#L16-L20).

That is getting controlled via USE=gmp-autoupdate which is enabled by default because we want users to receive updates.

Notice: Another popular GMP is the h264 plugin provided by CISCO to allow firefox to play h264 content (gmp-gmpopenh264). However, we have USE=openh264 enabled by default which will pull in media-libs/openh264[plugin] (should be the same like binary blob but build on your own). When openh264 is already present, firefox will use system lib instead and will *not* download any blob. However, the blob is stored in user's profile. So once it was downloaded and is present in profile, Firefox will keep using that blob despite the fact that you installed openh264 in the meanwhile. That's why we have auto-enabled USE=gmp-autoupdate to ensure that old installations will receive updated h264 plugin...
Comment 6 tt_1 2020-10-01 17:55:25 UTC
I find it rather confusing as well, there's an older bug with more informations on what --enable-eme actually does and how it lately changed: 

https://bugzilla.mozilla.org/show_bug.cgi?id=1528884

these informations are for the old 68-esr, but yes the issue of not wanting any of the binary blobs landing in users profile should be solved by setting the value via all-gentoo.js, or whatever that file is called where the so called sensible defaults for new profiles are provided.