Bug 744955 – net-firewall/nftables initscript does not export SAVE_OPTIONS into the environment of nftables.sh

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description fling 2020-09-27 15:48:00 UTC]

Setting SAVE_OPTIONS has no effect on the initscript.

Reproducible: Always

Steps to Reproduce:
1. change 'SAVE_OPTIONS="-n"' to 'SAVE_OPTIONS="-S"' in /etc/conf.d/nftables
2. /etc/init.d/nftables save
3. /etc/init.d/nftables reload
Actual Results:  
The options ignored.

Expected Results:  
Ports are translated to service names as described in /etc/services.

[Comment 1 Larry the Git Cow 2020-09-28 23:18:55 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ee0604e2b7263e058c65d222f4c654da3ffdbbd3

commit ee0604e2b7263e058c65d222f4c654da3ffdbbd3
Author:     Patrick McLean <[e-mail]>
AuthorDate: 2020-09-28 23:18:39 +0000
Commit:     Patrick McLean <[e-mail]>
CommitDate: 2020-09-28 23:18:39 +0000

    net-firewall/nftables-0.9.6-r1: revbump, fix init script (bug #744955)
    
    Closes: https://bugs.gentoo.org/744955
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Patrick McLean <[e-mail]>

 net-firewall/nftables/files/nftables.init-r1   | 105 ++++++++++++++++
 net-firewall/nftables/nftables-0.9.6-r1.ebuild | 162 +++++++++++++++++++++++++
 2 files changed, 267 insertions(+)

[Comment 2 Ross Charles C. 2020-09-29 05:45:24 UTC]

(In reply to Larry the Git Cow from comment #1)
> The bug has been closed via the following commit(s):
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=ee0604e2b7263e058c65d222f4c654da3ffdbbd3
> 
> commit ee0604e2b7263e058c65d222f4c654da3ffdbbd3
> Author:     Patrick McLean <[e-mail]>
> AuthorDate: 2020-09-28 23:18:39 +0000
> Commit:     Patrick McLean <[e-mail]>
> CommitDate: 2020-09-28 23:18:39 +0000
> 
>     net-firewall/nftables-0.9.6-r1: revbump, fix init script (bug #744955)
>     
>     Closes: https://bugs.gentoo.org/744955
>     Package-Manager: Portage-3.0.8, Repoman-3.0.1
>     Signed-off-by: Patrick McLean <[e-mail]>
> 
>  net-firewall/nftables/files/nftables.init-r1   | 105 ++++++++++++++++
>  net-firewall/nftables/nftables-0.9.6-r1.ebuild | 162
> +++++++++++++++++++++++++
>  2 files changed, 267 insertions(+)

Apparently the fix introduces other problems:
 * ERROR: net-firewall/nftables-0.9.6-r1::gentoo failed (install phase):
 *   !!! newinitd: /var/tmp/portage/net-firewall/nftables-0.9.6-r1/files/nftables-mk.init-r1 does not exist

[Comment 3 Larry the Git Cow 2020-11-08 02:59:42 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cb51431baffa2b5f38beb351274913f0d2768fc9

commit cb51431baffa2b5f38beb351274913f0d2768fc9
Author:     Patrick McLean <[e-mail]>
AuthorDate: 2020-11-08 02:59:20 +0000
Commit:     Patrick McLean <[e-mail]>
CommitDate: 2020-11-08 02:59:20 +0000

    net-firewall/nftables-0.9.7-r1: revbump, fix initd (bug #753491, #744955)
    
    Closes: https://bugs.gentoo.org/753491
    Closes: https://bugs.gentoo.org/744955
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Patrick McLean <[e-mail]>

 net-firewall/nftables/files/nftables-mk.init-r1 |  50 ++++----
 net-firewall/nftables/files/nftables.init-r1    | 154 ++++++++++++----------
 net-firewall/nftables/nftables-0.9.7-r1.ebuild  | 162 ++++++++++++++++++++++++
 net-firewall/nftables/nftables-0.9.7.ebuild     |   2 +-
 net-firewall/nftables/nftables-9999.ebuild      |   2 +-
 5 files changed, 280 insertions(+), 90 deletions(-)