Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 744730 - dev-libs/re2: consider switching to cmake
Summary: dev-libs/re2: consider switching to cmake
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-25 22:01 UTC by Georgy Yakovlev
Modified: 2020-09-26 06:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Georgy Yakovlev archtester gentoo-dev 2020-09-25 22:01:48 UTC
Hi!

net-libs/grpc now depends on re2, but searches it via cmake 

CMake Error at cmake/re2.cmake:48 (find_package):
  Could not find a package configuration file provided by "re2" with any of
  the following names:

    re2Config.cmake
    re2-config.cmake


I can patch it to fallback to pkg-config of course, but I think it would be better to provide cmake files along with .pc files in re2.

wdyt?
Comment 1 Arfrever Frehtes Taifersar Arahesis 2020-09-25 22:42:08 UTC
Not ready, at least for now:

https://github.com/google/re2/issues/259
https://github.com/google/re2/issues/274
https://github.com/google/re2/issues/277
Comment 2 Larry the Git Cow gentoo-dev 2020-09-25 22:55:23 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f4a04a5c28a13f2d5453847701a43572c5847d8f

commit f4a04a5c28a13f2d5453847701a43572c5847d8f
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-09-25 22:23:58 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-09-25 22:55:05 +0000

    net-libs/grpc: bump to 1.32.0
    
    Bug: https://bugs.gentoo.org/744730
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 net-libs/grpc/Manifest                             |  1 +
 .../grpc/files/use-pkg-config-to-find-re2.patch    | 26 +++++++
 net-libs/grpc/grpc-1.32.0.ebuild                   | 87 ++++++++++++++++++++++
 3 files changed, 114 insertions(+)
Comment 3 Georgy Yakovlev archtester gentoo-dev 2020-09-25 23:02:26 UTC
ok thanks for info.

patch turned out stupidly-simple, would not be too hard to maintain.

if you don't need this bug for tracking - feel free to close.
Comment 4 Arfrever Frehtes Taifersar Arahesis 2020-09-26 06:00:06 UTC
https://github.com/grpc/grpc/commit/45e413d2520795e7281e9a592af81620349bc186