Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 744364 - media-libs/libffado-2.4.1-r1 - ffado-mixer crashes(?) when loading config
Summary: media-libs/libffado-2.4.1-r1 - ffado-mixer crashes(?) when loading config
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-09-23 17:03 UTC by Adam Wenocur
Modified: 2022-11-28 08:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for libffado (fix-string-conversion.patch,728 bytes, patch)
2020-09-23 17:05 UTC, Adam Wenocur
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Wenocur 2020-09-23 17:03:20 UTC
When loading a saved XML config in ffado-mixer, it crashes due to old code that references a deprecated PyQt4 API. It is a trivial matter to fix this; the ebuild just needs an additional one-liner patch.

Reproducible: Always

Steps to Reproduce:
1.open ffado-mixer
2.(optional) save an XML config file representing the current settings
3.load a saved XML config file
Actual Results:  
application crashes with a Python exception

Expected Results:  
application loads config successfully

emerge --info media-libs/libffado:
Portage 2.3.103 (python 3.7.8-final-0, default/linux/amd64/17.0/desktop/gnome/systemd, gcc-9.3.0, glibc-2.30-r8, 5.7.10-x86_64 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.7.10-x86_64-x86_64-Intel-R-_Xeon-R-_CPU_E3-1235L_v5_@_2.00GHz-with-gentoo-2.6
KiB Mem:    32900500 total,   2026656 free
KiB Swap:   20971516 total,  20890620 free
sh bash 5.0_p17
ld GNU ld (Gentoo 2.32 p2) 2.32.0
distcc 3.3.3 x86_64-pc-linux-gnu [disabled]
app-shells/bash:          5.0_p17::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.30.3::gentoo
dev-lang/python:          2.7.18-r1::gentoo, 3.6.11-r2::gentoo, 3.7.8-r2::gentoo, 3.8.4-r1::gentoo
dev-util/cmake:           3.16.5::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/sandbox:         2.18::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.13.4-r2::gentoo, 1.15.1-r2::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.33.1-r1::gentoo
sys-devel/gcc:            9.3.0-r1::gentoo
sys-devel/gcc-config:     2.3::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.4-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.30-r8::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts: 
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1

asw-custom-software
    location: /mnt/bulk/software/gentoo
    masters: gentoo

binaryden
    location: /mnt/bulk/software/git/binaryden
    masters: gentoo

bioinformatics-overlay
    location: /mnt/bulk/software/bioinformatics-overlay
    masters: gentoo

rocm
    location: /mnt/bulk/software/rocm
    masters: gentoo

steam-overlay
    location: /mnt/bulk/software/steam-overlay
    masters: gentoo

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.2/ext-active/ /etc/php/apache2-php7.4/ext-active/ /etc/php/cgi-php7.2/ext-active/ /etc/php/cgi-php7.4/ext-active/ /etc/php/cli-php7.2/ext-active/ /etc/php/cli-php7.4/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -march=native"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=native"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 berkdb bluetooth branding bzip2 cairo cdda cdr cli colord crypt cups dbus dri dts dvd dvdr eds emboss encode evo exif flac fortran gdbm gif gnome gnome-keyring gnome-online-accounts gpm gstreamer gtk iconv icu introspection ipv6 jpeg lcms ldap libnotify libsecret libtirpc mad mng mp3 mp4 mpeg multilib nautilus ncurses networkmanager nls nptl ogg opengl openmp pam pango pcre pdf png policykit ppds pulseaudio qt5 readline sdl seccomp spell split-usr ssl startup-notification svg systemd tcpd tiff tracker truetype udev udisks unicode upower usb vorbis vulkan wxwidgets x264 xattr xcb xml xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="wacom" KERNEL="linux" L10N="en he fr" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2 php7-3" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_7" PYTHON_TARGETS="python2_7 python3_7" RUBY_TARGETS="ruby25" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, MAKEOPTS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

media-libs/libffado-2.4.1-r1::gentoo was built with the following:
USE="qt5 test-programs -debug" ABI_X86="32 (64) (-x32)" PYTHON_SINGLE_TARGET="python3_6"
Comment 1 Adam Wenocur 2020-09-23 17:05:33 UTC
Created attachment 662137 [details, diff]
patch for libffado

This patch removes a call to an obsolete PyQt4 API.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2020-09-24 11:43:07 UTC
commit 46fc84a6bd5f1873603ada7aa1fc803ccc9e6390
Author: Miroslav Šulc <fordfrog@gentoo.org>
Date:   Thu Sep 24 12:32:02 2020 +0200

    media-libs/libffado: removed obsolete 2.4.1-r1

    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

commit d54ef7c547cc693416cd7dc604c74b51d70d0648
Author: Agostino Sarubbo <ago@gentoo.org>
Date:   Thu Sep 24 08:46:25 2020 +0200

    media-libs/libffado: amd64 stable wrt bug #738730

    Package-Manager: Portage-2.3.103, Repoman-2.3.23
    RepoMan-Options: --include-arches="amd64"
    Signed-off-by: Agostino Sarubbo <ago@gentoo.org>

commit 9edef3366608ec98b186765c708d55106bd61966
Author: Thomas Deutschmann <whissi@gentoo.org>
Date:   Mon Sep 21 00:36:42 2020 +0200

    media-libs/libffado: x86 stable (bug #738730)

    Package-Manager: Portage-3.0.7, Repoman-3.0.1
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

commit 7cab3ae51ca2e75364f6aea0104d0b074692631f
Author: Miroslav Šulc <fordfrog@gentoo.org>
Date:   Fri Aug 21 10:23:58 2020 +0200

    media-libs/libffado: bump to 2.4.4

    1) eapi7
    2) added py3_7 and py3_8
    3) updated deps, dropped jack restriction as not needed

    Closes: https://bugs.gentoo.org/733996
    Closes: https://bugs.gentoo.org/737394
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>
Comment 3 Adam Wenocur 2020-12-19 20:01:08 UTC
This bug is still present in version 2.4.4. I will post an updated patch.
Comment 4 Adam Wenocur 2020-12-19 20:44:23 UTC
no need for another patch; the one I added at the top for 2.4.1 still works on 2.4.4
Comment 5 Larry the Git Cow gentoo-dev 2022-11-28 08:56:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c25d9d6e155fb609e375e6a85aeb585fde5a2f67

commit c25d9d6e155fb609e375e6a85aeb585fde5a2f67
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2022-11-28 08:55:55 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2022-11-28 08:56:44 +0000

    media-libs/libffado: bump to 2.4.7 + fix for config load crash
    
    patch by Adam Wenocur <awenocur@gmail.com>
    
    Closes: https://bugs.gentoo.org/744364
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-libs/libffado/Manifest                       |   1 +
 .../libffado-2.4.7-fix-config-load-crash.patch     |  13 +++
 media-libs/libffado/libffado-2.4.7.ebuild          | 125 +++++++++++++++++++++
 3 files changed, 139 insertions(+)