Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 744244 - sys-process/criu-3.14-r2 fails to compile
Summary: sys-process/criu-3.14-r2 fails to compile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-23 06:35 UTC by Agostino Sarubbo
Modified: 2020-09-24 09:26 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,105.94 KB, text/plain)
2020-09-23 06:35 UTC, Agostino Sarubbo
Details
env (env,3.01 KB, text/plain)
2020-09-24 07:15 UTC, Agostino Sarubbo
Details
environment (environment,137.79 KB, text/plain)
2020-09-24 07:44 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-09-23 06:35:54 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-process/criu-3.14-r2 fails to compile.
Discovered on: amd64 (internal ref: ci)

NOTE:
This machine uses GLIBC-2.32. If you think that this issue is strictly related to GLIBC please block bug 736174.
Comment 1 Agostino Sarubbo gentoo-dev 2020-09-23 06:35:56 UTC
Created attachment 662056 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2020-09-23 06:35:57 UTC
Possible context of error(s):

x86_64-pc-linux-gnu-ld: cannot find -lgcov
Comment 3 Georgy Yakovlev archtester gentoo-dev 2020-09-24 01:51:46 UTC
builds fine on glibc-2.32/gcc-9 here.

there's a condition in Makefile

FLAGS-GCOV             := --coverage -fno-exceptions -fno-inline -fprofile-update=atomic
export CFLAGS-GCOV

ifneq ($(GCOV),)
        LDFLAGS         += -lgcov
        CFLAGS          += $(CFLAGS-GCOV)
endif


and those flags are in your build log.

do you define envvar GCOV to something non-empty on tinderbox?

easy reproducer: 
GCOV=1 ebuild criu-3.14-r2.ebuild clean compile
Comment 4 Larry the Git Cow gentoo-dev 2020-09-24 01:53:05 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=904c2e8deaacb84fd58d152cf18e0f6ab2c5d0c5

commit 904c2e8deaacb84fd58d152cf18e0f6ab2c5d0c5
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-09-24 01:52:26 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-09-24 01:52:26 +0000

    sys-process/criu: don't fail with non-empty GCOV envvar
    
    Bug: https://bugs.gentoo.org/744244
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 sys-process/criu/criu-3.14-r2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Agostino Sarubbo gentoo-dev 2020-09-24 05:59:33 UTC
still reproducible for me
Comment 6 Georgy Yakovlev archtester gentoo-dev 2020-09-24 07:03:19 UTC
can you please attach your environment file?
Comment 7 Agostino Sarubbo gentoo-dev 2020-09-24 07:15:43 UTC
Created attachment 662254 [details]
env

Note that I test also the package with GCOV=x86_64-pc-linux-gnu-gcov
Comment 8 Agostino Sarubbo gentoo-dev 2020-09-24 07:16:20 UTC
cat /etc/portage/env/qa 
CC="x86_64-pc-linux-gnu-gcc"
CXX="x86_64-pc-linux-gnu-g++"
AR="x86_64-pc-linux-gnu-ar"
CPP="x86_64-pc-linux-gnu-gcc -E"
LD="x86_64-pc-linux-gnu-ld"
NM="x86_64-pc-linux-gnu-nm"
RANLIB="x86_64-pc-linux-gnu-ranlib"
GCOV="x86_64-pc-linux-gnu-gcov"
AS="x86_64-pc-linux-gnu-as"
STRIP="x86_64-pc-linux-gnu-strip"
OBJCOPY="x86_64-pc-linux-gnu-objcopy"
OBJDUMP="x86_64-pc-linux-gnu-objdump"
READELF="x86_64-pc-linux-gnu-readelf"
Comment 9 Georgy Yakovlev archtester gentoo-dev 2020-09-24 07:24:46 UTC
where do you set GCOV variable exactly?

I tried exporting, setting in /etc/portage/make.conf and /etc/portage/bashrc,
nothing breaks build for me now.

I meant for example /var/tmp/portage/sys-process/criu-3.14-r2/temp/environment
And another build log, with updated ebuild which includes 904c2e8deaacb84fd58d152cf18e0f6ab2c5d0c5

I can't figure out how you get -lgcov and --coverage -fno-exceptions -fno-inline -fprofile-update=atomic in your flags.


unless your tree is not up to date
Comment 10 Georgy Yakovlev archtester gentoo-dev 2020-09-24 07:25:04 UTC
ah sorry I see now, env file.
Comment 11 Georgy Yakovlev archtester gentoo-dev 2020-09-24 07:27:17 UTC
tried env file, just to make sure. still can't reproduce =)

please make sure tree is up to date.


if it is, I'll need both fresh build log and /var/tmp/portage/sys-process/criu-3.14-r2/temp/environment file
Comment 12 Agostino Sarubbo gentoo-dev 2020-09-24 07:43:37 UTC
(In reply to Georgy Yakovlev from comment #11)
> tried env file, just to make sure. still can't reproduce =)
> 
> please make sure tree is up to date.

It got into the CI because of the fix you pushed, so it is up-to-date. I'll attach environment.

Note that I can reproduce on two systems
Comment 13 Agostino Sarubbo gentoo-dev 2020-09-24 07:44:11 UTC
Created attachment 662257 [details]
environment

environment
Comment 14 Larry the Git Cow gentoo-dev 2020-09-24 08:29:29 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ae76b6469821f5685dd91b767f962c0ac06ef4b6

commit ae76b6469821f5685dd91b767f962c0ac06ef4b6
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-09-24 08:28:32 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-09-24 08:29:07 +0000

    sys-process/criu: unset GCOV completely
    
    Bug: https://bugs.gentoo.org/744244
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 sys-process/criu/criu-3.14-r2.ebuild | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Comment 15 Georgy Yakovlev archtester gentoo-dev 2020-09-24 08:31:20 UTC
^ this should help.

I was able to reproduce by running 'ebuild' as user without emerge/sudo/anything.

Please close if you can't reproduce.