Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 744205 - net-vpn/libreswan 4.0 - ../../mk/config.mk:133: Warning: Overriding PREFIX with deprecated variable INC_USRLOCAL
Summary: net-vpn/libreswan 4.0 - ../../mk/config.mk:133: Warning: Overriding PREFIX wi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Hans de Graaff
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-23 03:47 UTC by Reuben Farrelly
Modified: 2020-10-17 07:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Reuben Farrelly 2020-09-23 03:47:52 UTC
The existing 3.32 ebuilds for Libreswan are using a number of build variables which are being deprecated by upstream, which are causing warnings to be logged during the build:

    export INC_USRLOCAL=/usr
    export INC_MANDIR=share/man
    export INITSYSTEM=openrc
    export INC_RCDIRS=
    export INC_RCDEFAULT=/etc/init.d

Resulting in logs of these messages:

../../mk/config.mk:133: Warning: Overriding PREFIX with deprecated variable INC_USRLOCAL
../../mk/config.mk:241: Warning: Overriding INITDDIR_DEFAULT with deprecated variable INC_RCDEFAULT

A closer look in the source code at mk/config.mk has the following comments:

# Compatibility with old INC_USRLOCAL which was changed to PREFIX.
# We will overwrite PREFIX with INC_USRLOCAL until libreswan 4.2

# We will overwrite INITDDIRS with INC_RCDIRS until libreswan 4.2

# We will overwrite INITDDIR_DEFAULT with INC_RCDEFAULT until libreswan 4.2

In addition INC_MANDIR is also now obsoleted and is replaced with FINALMANDIR.  This is important because the existing ebuild installs man pages in /man5 and /man8 which is clearly not where these files should go.
Comment 1 Hans de Graaff gentoo-dev Security 2020-10-03 06:02:32 UTC
I don't see any of this in the 3.32 ebuild. I do see that these changes are now in upstream git. Perhaps you are using a live ebuild from an overlay?
Comment 2 Reuben Farrelly 2020-10-06 05:28:17 UTC
I'm tracking the existing in-tree ebuild but with this change to a local copy to pull in git upstream:

+if [[ ${PV} != 9999 ]]; then
+               SRC_URI="https://download.libreswan.org/${P}.tar.gz"
+               KEYWORDS="~amd64 ~ppc ~x86"
+else
+               inherit git-r3
+               EGIT_REPO_URI="https://github.com/libreswan/libreswan.git"
+               #EGIT_COMMIT="" 
+fi

It looks like I made a mistake in reporting this, in that some of these variable warnings are new to -git and not in 3.32.  Oops.  I suppose these will all become more important at the time of the next upstream release though.

However the INC_MANDIR definition is not new and was introduced in 3.23 so that one still might want to be updated:

v3.23 (January 25, 2018)
...
>> Makefiles: Fix INC_MANDIR to be share/man and add FINALMANDIR [Tuomo]
Comment 3 Hans de Graaff gentoo-dev Security 2020-10-09 08:07:50 UTC
I'll leave this open as a reminder when libreswan 4 is released.
Comment 4 Larry the Git Cow gentoo-dev 2020-10-17 07:02:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2ba4e811c5fbf1a925210f8b43e2f7cdb9baee84

commit 2ba4e811c5fbf1a925210f8b43e2f7cdb9baee84
Author:     Hans de Graaff <graaff@gentoo.org>
AuthorDate: 2020-10-17 07:02:35 +0000
Commit:     Hans de Graaff <graaff@gentoo.org>
CommitDate: 2020-10-17 07:02:35 +0000

    net-vpn/libreswan: add 4.0
    
    Closes: https://bugs.gentoo.org/744205
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Hans de Graaff <graaff@gentoo.org>

 net-vpn/libreswan/Manifest             |   1 +
 net-vpn/libreswan/libreswan-4.0.ebuild | 117 +++++++++++++++++++++++++++++++++
 2 files changed, 118 insertions(+)