Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 743802 - app-crypt/autofirma - New package
Summary: app-crypt/autofirma - New package
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-09-20 18:13 UTC by Jesús P Rey (Chuso)
Modified: 2020-09-25 11:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesús P Rey (Chuso) 2020-09-20 18:13:08 UTC
This is the signing software provided by Spanish government and required when submitting requests online: https://github.com/ctt-gob-es/clienteafirma
Comment 1 Jesús P Rey (Chuso) 2020-09-20 18:17:58 UTC
GitHub PR submitted: https://github.com/gentoo/gentoo/pull/17620
Comment 2 Jesús P Rey (Chuso) 2020-09-20 19:02:50 UTC
I moved the PR to drafts because I get a CI warning that I don't really know what it means: https://qa-reports.gentoo.org/output/gentoo-ci/0047fba21d/output.html#app-crypt/autofirma
Comment 3 Jonas Stein gentoo-dev 2020-09-20 20:56:16 UTC
Thank you for your contribution.
I had a short look these are my comments:

* We usually prefer to compile from source instead of copying .jar files
* The bugtracker is non-english, but as far I can read users claim that compilation fails.
* I suggest to add this package to guru first and monitor it a while before adding it to the tree. 
https://wiki.gentoo.org/wiki/Project:GURU
This will help you to get it spread faster. 
We had bad experience with new ebuilds by proxied maintainers who did not care for the package after adding it. Hence it can take a while until someone merges a new package to the main tree.

Join IRC on #gentoo-dev-help for questions about your ebuild.
Comment 4 Jesús P Rey (Chuso) 2020-09-21 18:10:26 UTC
Hi Jonas, thanks for your quick review and comments.

> We usually prefer to compile from source instead of copying .jar files

As stated in the PR, I tried to create an ebuild that compiles from source, but I found the build process for this project too complex for my scarce understanding of Java building process.

> The bugtracker is non-english, but as far I can read users claim that compilation fails.

There are a few issues in English, but yes, most of them are in Spanish because the intended audience of this software is Spanish residents.

Having a quick look at the open issues, I didn't find any related to building failures that was relevant (i.e., in most cases is a user error).

> I suggest to add this package to guru first and monitor it a while before adding it to the tree.

Thank you. I know Guru, but I never contributed to it.
I think I had some contribution to its predecessor Sunrise though.
I will give Guru a try.

> We had bad experience with new ebuilds by proxied maintainers who did not care for the package after adding it

Yes, I understand that can happen. That's why I don't try to become the maintainer for packages I don't actively use.

And yes, I'm usually in some Gentoo channels in Freenode :-)
Comment 5 Jesús P Rey (Chuso) 2020-09-21 20:58:42 UTC
I found what was causing the QA warnings and reopened the PR: https://github.com/gentoo/gentoo/pull/17620
Comment 6 Larry the Git Cow gentoo-dev 2020-09-24 13:01:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=00a6239592208b9e92c724994c36920896f46851

commit 00a6239592208b9e92c724994c36920896f46851
Author:     Jesus P Rey (Chuso) <gentoo@chuso.net>
AuthorDate: 2020-09-23 19:59:30 +0000
Commit:     Jesus P Rey (Chuso) <gentoo@chuso.net>
CommitDate: 2020-09-23 20:37:09 +0000

    app-crypt/autofirma-1.6.5 new package
    
    Signed-off-by: Jesus P Rey <gentoo@chuso.net>
    Closes: https://bugs.gentoo.org/743802

 app-crypt/autofirma/Manifest               |  1 +
 app-crypt/autofirma/autofirma-1.6.5.ebuild | 37 ++++++++++++++++++++++++++++++
 app-crypt/autofirma/metadata.xml           | 15 ++++++++++++
 3 files changed, 53 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=5781e38196be93e12093e8a742d832964011748e

commit 5781e38196be93e12093e8a742d832964011748e
Author:     Jesus P Rey (Chuso) <gentoo@chuso.net>
AuthorDate: 2020-09-23 20:44:14 +0000
Commit:     Jesus P Rey (Chuso) <gentoo@chuso.net>
CommitDate: 2020-09-23 20:46:39 +0000

    app-crypt/autofirma: Add missing version number to distfile.
    
    Signed-off-by: Jesus P Rey <gentoo@chuso.net>
    Bug: https://bugs.gentoo.org/743802

 app-crypt/autofirma/Manifest               | 2 +-
 app-crypt/autofirma/autofirma-1.6.5.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 7 Jesús P Rey (Chuso) 2020-09-24 13:31:41 UTC
Reopining since I closed it by mistake in a GURU commit :-)
Comment 8 Larry the Git Cow gentoo-dev 2020-09-25 11:39:15 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=21f3ddd6f5f71c09ee3f879da01c0f64359a04ed

commit 21f3ddd6f5f71c09ee3f879da01c0f64359a04ed
Author:     Jesus P Rey (Chuso) <gentoo@chuso.net>
AuthorDate: 2020-09-24 19:57:11 +0000
Commit:     Jesus P Rey (Chuso) <gentoo@chuso.net>
CommitDate: 2020-09-24 19:58:31 +0000

    app-crypt/autofirma-1.6.5-r1: Simplify and improve support for other browsers and ABIs.
    
    Signed-off-by: Jesus P Rey <gentoo@chuso.net>
    Bug: https://bugs.gentoo.org/743802

 .../{autofirma-1.6.5.ebuild => autofirma-1.6.5-r1.ebuild}     | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)