Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 742962 - net-dns/pdns: Incorrect pidfile path
Summary: net-dns/pdns: Incorrect pidfile path
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sven Wegener
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-16 14:09 UTC by Ruslan Kh.
Modified: 2020-09-22 21:55 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ruslan Kh. 2020-09-16 14:09:54 UTC
the script is looking for the pidfile in the wrong path
Due to changelog for pdns updated 4.2.x to 4.3.0

https://doc.powerdns.com/authoritative/upgrading.html#socket-dir-changed

> The default socket-dir has changed to include pdns in the path. It is now
> whatever is passed to --with-socketdir during configure (/var/run by default)
> plus pdns.

in /etc/init.d/pdns we have:
pidfile="${PDNS_CHROOTDIR}/${PDNS_SOCKETDIR}/pdns${PDNS_INSTANCE:+-${PDNS_INSTANCE}}.pid"
translated to /var/run/pdns.pid
correct location for pidfile is - /var/run/pdns/pdns.pid (sample, without instance name)

Reproducible: Always

Steps to Reproduce:
1. Install
2. Start /etc/init.d/pdns
3. In rc-status and /var/log/messages - process looks like was crashed, but pdns_server running and processing requests
Comment 1 Ruslan Kh. 2020-09-16 14:12:52 UTC
build ~ # emerge --info
Portage 2.3.103 (python 3.7.8-final-0, default/linux/amd64/17.1/no-multilib/hardened, gcc-9.3.0, glibc-2.31-r6, 5.4.38-gentoo-x86_64 x86_64)
=================================================================
System uname: Linux-5.4.38-gentoo-x86_64-x86_64-AMD_Ryzen_7_2700X_Eight-Core_Processor-with-gentoo-2.6
KiB Mem:    16309928 total,    794208 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Mon, 31 Aug 2020 19:30:01 +0000
Head commit of repository gentoo: 4701ee1525a4e81a5b7a03b3140e80fe61a6a1d2
sh bash 5.0_p17
ld GNU ld (Gentoo 2.33.1 p2) 2.33.1
ccache version 3.7.10 [enabled]
app-shells/bash:          5.0_p17::gentoo
dev-lang/perl:            5.30.3::gentoo
dev-lang/python:          2.7.18-r1::gentoo, 3.7.8-r2::gentoo, 3.8.4-r1::gentoo
dev-util/ccache:          3.7.10::gentoo
dev-util/cmake:           3.16.5::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.18::gentoo
sys-devel/autoconf:       2.69-r4::gentoo
sys-devel/automake:       1.16.1-r1::gentoo
sys-devel/binutils:       2.33.1-r1::gentoo
sys-devel/gcc:            9.3.0-r1::gentoo
sys-devel/gcc-config:     2.3.1::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.4-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.31-r6::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts: 
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=znver1 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/easy-rsa /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=znver1 -O2 -pipe"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--jobs 20 --with-bdeps=y --usepkg-exclude 'sys-kernel/gentoo-sources'"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-march=znver1 -O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg candy ccache compress-build-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms sign strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=znver1 -O2 -pipe"
GENTOO_MIRRORS="rsync://gentoo.bloodhost.ru/gentoo-distfiles https://mirror.yandex.ru/gentoo-distfiles/ http://mirror.yandex.ru/gentoo-distfiles/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en_US en ru ru_RU"
MAKEOPTS="-j20 -l16"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl amd64 bash-completion bzip2 crypt hardened iconv ipv6 libglvnd libtirpc ncurses nls nptl openmp pam pcre pie readline seccomp split-usr ssl ssp tty-helpers unicode xattr xfs xtpax zeroconf zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="X86" NGINX_MODULES_HTTP="access addition auth_basic auth_request autoindex browser charset degradation fastcgi fancyindex geo gunzip gzip gzip_static image_filter limit_req mp4 proxy random_index realip referer rewrite secure_link ssi stub_status sub upstream_ip_hash upstream_keepalive userid xslt cache_purge headers_more limit_conn map metrics mirror push_stream upload_progress upstream_check upstream_hash upstream_least_conn upstream_zone vhost_traffic_status uwsgi" NGINX_MODULES_MAIL="imap pop3 smtp" NGINX_MODULES_STREAM="access geo geoip limit_conn map realip return split_clients upstream_hash upstream_least_conn upstream_zone geoip realip" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2 php7-3" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_7" PYTHON_TARGETS="python2_7 python3_7" RUBY_TARGETS="ruby25" USERLAND="GNU" VIDEO_CARDS="nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 2 pva 2020-09-16 14:19:42 UTC
Or we need the following patch to fix this problem:

--- files/pdns-r1	2017-05-25 15:04:46.000000000 -0000
+++ files/pdns-r1	2020-09-16 13:52:01.266985894 -0000
@@ -27,7 +27,7 @@
 command_args_background="--daemon=yes"
 yesno ${rc_verbose} || command_args_background="${command_args_background} >/dev/null 2>&1"
 
-pidfile="${PDNS_CHROOTDIR}/${PDNS_SOCKETDIR}/pdns${PDNS_INSTANCE:+-${PDNS_INSTANCE}}.pid"
+pidfile="${PDNS_CHROOTDIR}/${PDNS_SOCKETDIR}/pdns/pdns${PDNS_INSTANCE:+-${PDNS_INSTANCE}}.pid"
 
 control_command="/usr/bin/pdns_control"
 control_command_args="${command_args}"
Comment 3 Anna Tikhomirova 2020-09-22 18:15:46 UTC
(In reply to pva from comment #2)
> Or we need the following patch to fix this problem:
> 

Your patch is wrong. It is the default setting that changed. Do not add "pdns" to a custom setting if it exists. Proper patch:

diff -u pdns-r1.old pdns-r1
--- pdns-r1.old 2020-09-22 21:12:38.601652695 +0300
+++ pdns-r1     2020-09-22 21:12:08.490220046 +0300
@@ -10,7 +10,7 @@
 PDNS_CONFIG="${PDNS_CONFIGDIR}/pdns${PDNS_INSTANCE:+-${PDNS_INSTANCE}}.conf"
 PDNS_CHROOTDIR="$( awk -F = '$1 == "chroot" { print $2 }' "${PDNS_CONFIG}" )"
 PDNS_SOCKETDIR="$( awk -F = '$1 == "socket-dir" { print $2 }' "${PDNS_CONFIG}" )"
-[ -z "${PDNS_SOCKETDIR}" -a -z "${PDNS_CHROOTDIR}" ] && PDNS_SOCKETDIR="/var/run"
+[ -z "${PDNS_SOCKETDIR}" -a -z "${PDNS_CHROOTDIR}" ] && PDNS_SOCKETDIR="/var/run/pdns"

 name="PowerDNS Authoritative Server${PDNS_INSTANCE:+ (${PDNS_INSTANCE})}"
 description="Authoritative name server"
Comment 4 pva 2020-09-22 18:36:38 UTC
(In reply to Anna Tikhomirova from comment #3)
> Your patch is wrong. It is the default setting that changed. Do not add
> "pdns" to a custom setting if it exists.

Agreed. Actually, it was a quick fix and serves as an illustration of a problem. Thanks for correcting though.
Comment 5 Larry the Git Cow gentoo-dev 2020-09-22 21:55:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=85a794ee3a6f0bb17a0d669d1f37b1fa4204fca3

commit 85a794ee3a6f0bb17a0d669d1f37b1fa4204fca3
Author:     Sven Wegener <swegener@gentoo.org>
AuthorDate: 2020-09-22 21:21:17 +0000
Commit:     Sven Wegener <swegener@gentoo.org>
CommitDate: 2020-09-22 21:41:55 +0000

    net-dns/pdns: Fix default pidfile location, bug #742962
    
    Closes: https://bugs.gentoo.org/742962
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Sven Wegener <swegener@gentoo.org>

 net-dns/pdns/files/pdns-r1 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)