Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 742392 - kde-plasma/plasma-workspace-5.19.5[gps] with sci-geosciences/gpsd-3.21: location_gps.cpp:68:32: error: ‘struct gps_data_t’ has no member named ‘status’
Summary: kde-plasma/plasma-workspace-5.19.5[gps] with sci-geosciences/gpsd-3.21: locat...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: PATCH
: 745957 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-09-13 15:07 UTC by PhobosK
Modified: 2020-10-10 07:41 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gpsd_3_21-fix.patch (gpsd_3_21-fix.patch,985 bytes, patch)
2020-09-13 15:10 UTC, PhobosK
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description PhobosK 2020-09-13 15:07:51 UTC
Due to API changes in gpsd 3.21 that was recently introduced in portage tree, an error when compiling kde-plasma/plasma-workspace-5.19.5[gps] appears:


FAILED: dataengines/geolocation/CMakeFiles/plasma-geolocation-gps.dir/location_gps.cpp.o 
/usr/bin/x86_64-pc-linux-gnu-g++ -DKCOREADDONS_LIB -DQT_CORE_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_URL_CAST_FROM_STRING -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Dplasma_geolocation_gps_EXPORTS -Idataengines/geolocation -I/dev/shm/portage/kde-plasma/plasma-workspace-5.19.5/work/plasma-workspace-5.19.5/dataengines/geolocation -Idataengines/geolocation/plasma-geolocation-gps_autogen/include -I. -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/KF5 -isystem /usr/include/KF5/Plasma -isystem /usr/include/KF5/KService -isystem /usr/include/KF5/KConfigCore -isystem /usr/include/KF5/KCoreAddons -isystem /usr/include/qt5/QtGui -isystem /usr/include/KF5/KPackage  -DQT_NO_DEBUG -march=native -O2 -pipe -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Wvla -Wdate-time -Wsuggest-override -Wlogical-op -fdiagnostics-color=always -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -std=gnu++11 -MD -MT dataengines/geolocation/CMakeFiles/plasma-geolocation-gps.dir/location_gps.cpp.o -MF dataengines/geolocation/CMakeFiles/plasma-geolocation-gps.dir/location_gps.cpp.o.d -o dataengines/geolocation/CMakeFiles/plasma-geolocation-gps.dir/location_gps.cpp.o -c /dev/shm/portage/kde-plasma/plasma-workspace-5.19.5/work/plasma-workspace-5.19.5/dataengines/geolocation/location_gps.cpp
/dev/shm/portage/kde-plasma/plasma-workspace-5.19.5/work/plasma-workspace-5.19.5/dataengines/geolocation/location_gps.cpp: In member function ‘virtual void Gpsd::run()’:
/dev/shm/portage/kde-plasma/plasma-workspace-5.19.5/work/plasma-workspace-5.19.5/dataengines/geolocation/location_gps.cpp:68:32: error: ‘struct gps_data_t’ has no member named ‘status’
   68 |                 if (m_gpsdata->status != STATUS_NO_FIX) {
      |                                ^~~~~~
ninja: build stopped: subcommand failed.





Upstream fixed the error with this commit: https://github.com/KDE/plasma-workspace/commit/e3134289f522edb140797818fffd60d641b86cd8

So I am uploading the upstream patch needed... 
Can be added to the ebuild to fix the issue.

Tested and works OK on ~amd64

Thanks

Reproducible: Always
Comment 1 PhobosK 2020-09-13 15:10:21 UTC
Created attachment 660039 [details, diff]
gpsd_3_21-fix.patch

The needed patch for the API changes in gpsd 3.21

Can be applied as a user patch also in: /etc/portage/patches/kde-plasma/plasma-workspace-5.19.5/gpsd_3_21-fix.patch
Comment 2 Fabio Coatti 2020-09-14 07:23:27 UTC
Confirmed both the issue and the effectiveness of the patch. Many thanks!
Comment 3 Larry the Git Cow gentoo-dev 2020-09-17 20:15:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=387c395751705c65010a74508f4df48be238f9df

commit 387c395751705c65010a74508f4df48be238f9df
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-09-16 17:01:42 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-09-17 20:14:47 +0000

    kde-plasma/plasma-workspace: Fix build with sci-geosciences/gpsd-3.21
    
    Thanks-to: PhobosK <phobosk@fastmail.fm>
    Closes: https://bugs.gentoo.org/742392
    Package-Manager: Portage-3.0.7, Repoman-3.0.1
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/plasma-workspace-5.19.5-gpsd-3.21.patch  | 29 ++++++++++++++++++++++
 .../plasma-workspace-5.19.5.ebuild                 |  1 +
 2 files changed, 30 insertions(+)
Comment 4 Raimonds Cicans 2020-09-28 16:33:25 UTC
FYI same problem exists with kde-plasma/plasma-workspace-5.18.5-r1
Attached to this bug patch works also in this case.
Comment 5 Andreas Sturmlechner gentoo-dev 2020-10-10 07:41:12 UTC
*** Bug 745957 has been marked as a duplicate of this bug. ***