Bug 741972 – app-arch/zstd-1.4.4-r4: uclibc-ng fails to compile with 'stat_t' {aka 'struct stat'} has no member named 'st_mtim'

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description David Flogeras 2020-09-12 20:29:57 UTC]

Summary really says it all.  emerge --info:

Portage 2.3.99 (python 3.7.8-final-0, default/linux/arm/17.0/uclibc/armv6j, gcc-9.3.0, uclibc-ng-1.0.30-r1, 5.4.60-gentoo armv6l)
=================================================================
System uname: Linux-5.4.60-gentoo-armv6l-Intel-R-_Core-TM-_i7-4770_CPU_@_3.40GHz-with-gentoo-2.6
KiB Mem:    16334696 total,   2348276 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Fri, 11 Sep 2020 23:30:01 +0000
Head commit of repository gentoo: a6cd283d479970af452bd05246205a668381c8ec
sh bash 5.0_p17
ld GNU ld (Gentoo 2.33.1 p2) 2.33.1
app-shells/bash:          5.0_p17::gentoo
dev-lang/perl:            5.30.3::gentoo
dev-lang/python:          2.7.18::gentoo, 3.7.8-r1::gentoo
dev-util/cmake:           3.16.5::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.18::gentoo
sys-devel/autoconf:       2.69-r4::gentoo
sys-devel/automake:       1.16.1-r1::gentoo
sys-devel/binutils:       2.33.1-r1::gentoo
sys-devel/gcc:            9.3.0-r1::gentoo
sys-devel/gcc-config:     2.3::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.19::gentoo (virtual/os-headers)
sys-libs/uclibc-ng:       1.0.30-r1::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: no
    sync-rsync-extra-opts: 
    sync-rsync-verify-max-age: 24

x-portage
    location: /usr/local/portage
    masters: gentoo
    priority: 0

ACCEPT_KEYWORDS="arm"
ACCEPT_LICENSE="@FREE"
CBUILD="armv6j-unknown-linux-uclibceabihf"
CFLAGS="-march=armv6j -mfpu=vfp -mfloat-abi=hard -pipe -O2"
CHOST="armv6j-unknown-linux-uclibceabihf"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=armv6j -mfpu=vfp -mfloat-abi=hard -pipe -O2"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -march=armv6j -mfpu=vfp -mfloat-abi=hard"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox news nodoc noinfo noman parallel-fetch preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=armv6j -mfpu=vfp -mfloat-abi=hard"
GENTOO_MIRRORS="http://mirror.its.dal.ca/gentoo"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en"
MAKEOPTS="-j8"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl arm bzip2 cli crypt dri gdbm iconv libglvnd ncurses nptl openmp pcre readline seccomp split-usr ssl tcpd uclibc unicode xattr zlib" ADA_TARGET="gnat_2018" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="uclibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput evdev" KERNEL="linux" L10N="en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2 php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_7" PYTHON_TARGETS="python2_7 python3_7" RUBY_TARGETS="ruby25" USERLAND="GNU" VIDEO_CARDS="exynos fbdev omap dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

Reproducible: Always

[Comment 1 Ionen Wolkens 2020-09-12 20:41:09 UTC]

Haven't tried but I believe it's fixed in 1.4.5, which isn't stable in ::gentoo yet.

Upstream issue:
https://github.com/facebook/zstd/issues/1872

[Comment 2 Ionen Wolkens 2020-09-12 20:45:15 UTC]

(In reply to Ionen Wolkens from comment #1)
> Haven't tried but I believe it's fixed in 1.4.5, which isn't stable in
> ::gentoo yet.

My bad, looked at the dates wrong. I guess fix will be included in the next release.

[Comment 3 Ionen Wolkens 2020-09-12 20:52:21 UTC]

(In reply to Ionen Wolkens from comment #2)
> My bad, looked at the dates wrong. I guess fix will be included in the next
> release.
Well, assuming the 2nd part is needed. The there's two fix for it (one included in 1.4.5, and a second one that isn't).

May want to just try to 1.4.5 to see if it works.

[Comment 4 David Flogeras 2020-09-13 12:23:05 UTC]

Thanks Ionen for directing me!

1.4.5 also does not compile as is in portage.  But if I grab just this patch (from the linked bug):

https://github.com/facebook/zstd/commit/1dcc4787965aa8f4af48ed5a2154185750bbaff5.patch

and apply it to 1.4.4-r4 and/or 1.4.5, they both compile.  I'll leave this open, not sure what the policy is for backporting, or if we just wait until the next release.

[Comment 5 tt_1 2020-09-20 15:55:55 UTC]

it would be great to have the fix from https://github.com/facebook/zstd/pull/2243 in tree, since this breaks the stage3's with sys-apps/portage demanding it in RDEPS

if it helps, I can open a pullrequest. 

thanks

[Comment 6 tt_1 2020-09-27 09:11:16 UTC]

here's pullrequest: https://github.com/gentoo/gentoo/pull/17691

[Comment 7 .:deadhead:. 2020-10-06 13:52:35 UTC]

Same problem here on i686 + uclibc.
Confirm that patches provided on github works well.

[Comment 8 Larry the Git Cow 2020-10-06 13:59:56 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=140cb6ad1f0a8d8217453aa2ccb16e00d5a02c0a

commit 140cb6ad1f0a8d8217453aa2ccb16e00d5a02c0a
Author:     stefson <[e-mail]>
AuthorDate: 2020-09-27 08:26:54 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2020-10-06 13:53:59 +0000

    app-arch/zstd: fix compile with uclibc
    
    Closes: https://bugs.gentoo.org/741972
    
    Signed-off-by: Steffen Kuhn <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/17691
    Signed-off-by: Sam James <[e-mail]>

 app-arch/zstd/files/zstd-1.4.5-fix-uclibc-ng.patch | 28 ++++++++++++++++++++++
 app-arch/zstd/zstd-1.4.4-r4.ebuild                 |  1 +
 app-arch/zstd/zstd-1.4.5.ebuild                    |  4 ++++
 3 files changed, 33 insertions(+)