Created attachment 659130 [details] hikari 2.2.0 ebuild Suggested ebuild attached
Created attachment 659132 [details, diff] Makefile patch Suggested Makefile patch attached
Created attachment 659134 [details] hikari 2.2.0 ebuild Previous ebuild contains some hackery, apologies.
Thank you. Whoever wrote it: What does # keep this as others OS's are using this as reference mean here? Please improve the comment.
Thank you for the ebuild tried to build with USE="-X", got : compilation terminated. make: *** [Makefile:188: renderer.o] Error 1 make: *** Waiting for unfinished jobs.... src/server.c:38:10: fatal error: wlr/xwayland.h: No such file or directory 38 | #include <wlr/xwayland.h> I can provide environment, build.log and all if needed.
(In reply to Arnaud Vallette d'Osia from comment #4) > Thank you for the ebuild > tried to build with USE="-X", got : > > compilation terminated. > make: *** [Makefile:188: renderer.o] Error 1 > make: *** Waiting for unfinished jobs.... > src/server.c:38:10: fatal error: wlr/xwayland.h: No such file or directory > 38 | #include <wlr/xwayland.h> > > I can provide environment, build.log and all if needed. Being fixed here- https://github.com/gentoo/gentoo/pull/17262
(In reply to Jonas Stein from comment #3) > Thank you. > > Whoever wrote it: What does > # keep this as others OS's are using this as reference > mean here? Please improve the comment. @jstein am removing that patch in next bump will no longer be maintained here
(In reply to Aisha Tammy from comment #6) > am removing that patch in next bump This makes me happy :) Thanks, Aisha, it will be much easier to test hikari patches without the GNU patch!
Created attachment 663184 [details] Proposed ebuild using BSD make Updated bug to bump to 2.2.1, which has some minor bugfixes, especially relevant for multiple displays. I am also attaching a proposed ebuild, and took the liberty to modify it to use BSD make, thus ditching the patch to make it GNU compatible. As always, I'm still inexperienced with ebuilds, so it just works on my machines (tm) :)
@gabriel I've created a PR which should do the bump. I couldn't use your attached ebuild, because gentoo internals need a few more exports and esoterics, but I'd love if you could check if it works for you. Thanks :D
Aisha, Just tested quickly with `ebuild manifest install` - all seems good. Saw your comments upstream about PKG_CONFIG, which I now know is due to cross compiling :) Thanks!
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0427a37465ea8f29385a91233ba53772303e3fef commit 0427a37465ea8f29385a91233ba53772303e3fef Author: Aisha Tammy <gentoo@aisha.cc> AuthorDate: 2020-09-30 12:57:42 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2020-10-16 06:03:57 +0000 gui-wm/hikari: version bump to 2.2.1 and pkg-config calling as well Closes: https://bugs.gentoo.org/741164 Package-Manager: Portage-3.0.8, Repoman-3.0.1 Signed-off-by: Aisha Tammy <gentoo@aisha.cc> Signed-off-by: Joonas Niilola <juippis@gentoo.org> gui-wm/hikari/Manifest | 1 + gui-wm/hikari/files/hikari-2.2.1-pkgconfig.patch | 78 ++++++++++++++++++++++++ gui-wm/hikari/hikari-2.2.1.ebuild | 64 +++++++++++++++++++ 3 files changed, 143 insertions(+)
