Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 741088 - net-print/hplip-3.20.6-r1 fails to compile
Summary: net-print/hplip-3.20.6-r1 fails to compile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Daniel Pielmeier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-08 07:10 UTC by Agostino Sarubbo
Modified: 2020-09-25 13:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,473.54 KB, text/plain)
2020-09-08 07:10 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-09-08 07:10:15 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-print/hplip-3.20.6-r1 fails to compile.
Discovered on: amd64 (internal ref: tinderbox)

NOTE:
This machine uses a clang/LLVM toolchain.
If you think that this issue is strictly related to clang/LLVM please block bug 408963. If you think that this issue is strictly related to the LLD linker, please block bug 731004.
This machine uses also GLIBC-2.32. If you think that this issue is strictly related to GLIBC please block bug 736174.
Comment 1 Agostino Sarubbo gentoo-dev 2020-09-08 07:10:18 UTC
Created attachment 659086 [details]
build.log

build log and emerge --info
Comment 2 Daniel Pielmeier gentoo-dev 2020-09-24 20:21:53 UTC
Don't know in which category this falls. It seems that clang treats void functions returning a value as an error while gcc only issues a warning.

CLANG:
scan/sane/hpaio.c:425:8: error: void function 'sane_hpaio_close' should not return a value [-Wreturn-type]
       return orblite_close(handle);
       ^      ~~~~~~~~~~~~~~~~~~~~~

scan/sane/hpaio.c:558:8: error: void function 'sane_hpaio_cancel' should not return a value [-Wreturn-type]
       return orblite_cancel(handle);
       ^      ~~~~~~~~~~~~~~~~~~~~~~

GCC:
scan/sane/hpaio.c:425:15: warning: ‘return’ with a value, in function returning void
  425 |        return orblite_close(handle);
      |               ^~~~~~~~~~~~~~~~~~~~~

scan/sane/hpaio.c:558:15: warning: ‘return’ with a value, in function returning void
  558 |        return orblite_cancel(handle);
      |               ^~~~~~~~~~~~~~~~~~~~~~

prnt/hpps/hppsfilter.c:107:20: warning: ‘return’ with a value, in function returning void
  107 |             return 1;
      |                    ^
Comment 3 tt_1 2020-09-25 08:47:58 UTC
I think *somewhere* in that bunch of open upstream bugs there's a patch for compiling with clang.
Comment 4 Daniel Pielmeier gentoo-dev 2020-09-25 09:06:02 UTC
(In reply to tt_1 from comment #3)
> I think *somewhere* in that bunch of open upstream bugs there's a patch for
> compiling with clang.

Yes you are correct. Below the upstream bugs. At a first glance it seems they are addressing the issue. I will take a loo at them

https://bugs.launchpad.net/hplip/+bug/1842132
https://bugs.launchpad.net/hplip/+bug/1840490
Comment 5 Larry the Git Cow gentoo-dev 2020-09-25 13:17:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=79ed43dde0d79b213d97f4e7955304c488a8f6f2

commit 79ed43dde0d79b213d97f4e7955304c488a8f6f2
Author:     Daniel Pielmeier <billie@gentoo.org>
AuthorDate: 2020-09-25 13:17:36 +0000
Commit:     Daniel Pielmeier <billie@gentoo.org>
CommitDate: 2020-09-25 13:17:36 +0000

    net-print/hplip: Revision bump to hplip-3.20.6-r2.
    
    Add python 3.9 support.
    Add a proper patch for pythoncludes which also repects CFLAGS.
    Fix build with clang.
    Do not install systemd service for plugin/firmware handling.
    
    Closes: https://bugs.gentoo.org/739526
    Closes: https://bugs.gentoo.org/741088
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Daniel Pielmeier <billie@gentoo.org>

 net-print/hplip/Manifest               |   1 +
 net-print/hplip/hplip-3.20.6-r2.ebuild | 278 +++++++++++++++++++++++++++++++++
 2 files changed, 279 insertions(+)